Remove deprecated constants from RFC7231 for date formats

Author: natanfelles

src/Cookie.php

@@ -10,7 +10,6 @@
 namespace Framework\HTTP;
 
 use DateTime;
-use DateTimeInterface;
 use DateTimeZone;
 use Exception;
 use InvalidArgumentException;
@@ -64,7 +63,7 @@ public function toString() : string
         $string = $this->getName() . '=' . $this->getValue();
         $part = $this->getExpires();
         if ($part !== null) {
-            $string .= '; expires=' . $this->expires->format(DateTimeInterface::RFC7231);
+            $string .= '; expires=' . $this->expires->format('D, d M Y H:i:s \G\M\T');
             $string .= '; Max-Age=' . $this->expires->diff(new DateTime('-1 second'))->s;
         }
         $part = $this->getPath();

src/Response.php

@@ -10,7 +10,6 @@
 namespace Framework\HTTP;
 
 use DateTime;
-use DateTimeInterface;
 use DateTimeZone;
 use Framework\HTTP\Debug\HTTPCollector;
 use InvalidArgumentException;
@@ -796,7 +795,7 @@ public function setDate(DateTime $datetime) : static
         $date->setTimezone(new DateTimeZone('UTC'));
         $this->setHeader(
             ResponseHeader::DATE,
-            $date->format(DateTimeInterface::RFC7231)
+            $date->format('D, d M Y H:i:s \G\M\T')
         );
         return $this;
     }
@@ -836,7 +835,7 @@ public function setExpires(DateTime $datetime) : static
         $date->setTimezone(new DateTimeZone('UTC'));
         $this->setHeader(
             ResponseHeader::EXPIRES,
-            $date->format(DateTimeInterface::RFC7231)
+            $date->format('D, d M Y H:i:s \G\M\T')
         );
         return $this;
     }
@@ -856,7 +855,7 @@ public function setLastModified(DateTime $datetime) : static
         $date->setTimezone(new DateTimeZone('UTC'));
         $this->setHeader(
             ResponseHeader::LAST_MODIFIED,
-            $date->format(DateTimeInterface::RFC7231)
+            $date->format('D, d M Y H:i:s \G\M\T')
         );
         return $this;
     }

src/ResponseDownload.php

@@ -86,7 +86,10 @@ public function setDownload(
                 "Could not get the file modification time of '{$this->filepath}'"
             );
         }
-        $this->setHeader(ResponseHeader::LAST_MODIFIED, \gmdate(\DATE_RFC7231, $filemtime));
+        $this->setHeader(
+            ResponseHeader::LAST_MODIFIED,
+            \gmdate('D, d M Y H:i:s \G\M\T', $filemtime)
+        );
         $filename ??= \basename($filepath);
         $filename = \htmlspecialchars($filename, \ENT_QUOTES | \ENT_HTML5);
         $filename = \strtr($filename, ['/' => '_', '\\' => '_']);

tests/ResponseTest.php

@@ -437,7 +437,7 @@ public function testToString() : void
     {
         $startLine = 'HTTP/1.1 200 OK';
         $headerLines = [
-            'Date: ' . \gmdate(\DATE_RFC7231),
+            'Date: ' . \gmdate('D, d M Y H:i:s \G\M\T'),
             'Content-Type: text/html; charset=UTF-8',
         ];
         $body = <<<'HTML'
@@ -463,7 +463,7 @@ public function testToStringWithoutBodyAndContentType() : void
     {
         $startLine = 'HTTP/1.1 200 OK';
         $headerLines = [
-            'Date: ' . \gmdate(\DATE_RFC7231),
+            'Date: ' . \gmdate('D, d M Y H:i:s \G\M\T'),
         ];
         $message = $startLine . "\r\n"
             . \implode("\r\n", $headerLines) . "\r\n"
@@ -478,12 +478,12 @@ public function testToStringWithDownload() : void
         $length = \strlen($body);
         $startLine = 'HTTP/1.1 200 OK';
         $headerLines = [
-            'Last-Modified: ' . \gmdate(\DATE_RFC7231, (int) \filemtime($filename)),
+            'Last-Modified: ' . \gmdate('D, d M Y H:i:s \G\M\T', (int) \filemtime($filename)),
             'Content-Disposition: attachment; filename="file.txt"',
             'Accept-Ranges: bytes',
             'Content-Length: ' . $length,
             'Content-Type: text/plain',
-            'Date: ' . \gmdate(\DATE_RFC7231),
+            'Date: ' . \gmdate('D, d M Y H:i:s \G\M\T'),
         ];
         $this->response->setDownload($filename);
         $message = $startLine . "\r\n"
@@ -515,12 +515,12 @@ public function testToStringWithDownloadMultipart() : void
         $length = \strlen($body);
         $startLine = 'HTTP/1.1 206 Partial Content';
         $headerLines = [
-            'Last-Modified: ' . \gmdate(\DATE_RFC7231, (int) \filemtime($filename)),
+            'Last-Modified: ' . \gmdate('D, d M Y H:i:s \G\M\T', (int) \filemtime($filename)),
             'Content-Disposition: attachment; filename="fo_o.b&quot;ar"',
             'Accept-Ranges: bytes',
             'Content-Length: ' . $length,
             'Content-Type: multipart/x-byteranges; boundary=' . $boundary,
-            'Date: ' . \gmdate(\DATE_RFC7231),
+            'Date: ' . \gmdate('D, d M Y H:i:s \G\M\T'),
         ];
         $this->response->setDownload($filename, filename: 'fo/o.b"ar');
         $message = $startLine . "\r\n"