Skip to content

Commit 057ce83

Browse files
murhum1ihalaij1
authored andcommitted
Don't retain inputs for feedback exercises
mooc-jutut submissions were being autofilled to have the previous submission's input, which was potentially confusing for students. This fixes that by excluding exercises with the "feedback" class.
1 parent 7ec2168 commit 057ce83

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

exercise/static/exercise/chapter.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,9 +382,10 @@
382382
exercise.update($(data));
383383
const hasTextarea = exercise.element.find('textarea').length > 0;
384384
const hasFieldset = exercise.element.find('fieldset').length > 0;
385+
const isFeedback = exercise.element.hasClass("feedback");
385386
if (exercise.active_element) {
386387
exercise.loadLastSubmission($(data));
387-
} else if (hasTextarea && !hasFieldset) { // Identify acceptPost exercises
388+
} else if (hasTextarea && !hasFieldset && !isFeedback) { // Identify acceptPost exercises
388389
exercise.loadLastSubmission($(data), true);
389390
} else {
390391
exercise.renderMath();
@@ -669,7 +670,8 @@
669670

670671
const hasTextarea = exercise.element.find('textarea').length > 0;
671672
const hasFieldset = exercise.element.find('fieldset').length > 0;
672-
if (hasTextarea && !hasFieldset) { // Identify acceptPost exercises
673+
const isFeedback = exercise.element.hasClass("feedback");
674+
if (hasTextarea && !hasFieldset && !isFeedback) { // Identify acceptPost exercises
673675
// Save form data to restore after update
674676
exercise.savedFormData = Array.from(formData.entries());
675677
}

0 commit comments

Comments
 (0)