Skip to content

Commit 90869dd

Browse files
committed
remove references to Selenium tests
1 parent b2c0423 commit 90869dd

6 files changed

Lines changed: 1 addition & 68 deletions

File tree

.github/workflows/Dockerfile

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
FROM ubuntu:22.04
22

3-
ARG GECKODRIVER_VERSION=0.33.0
4-
ARG GECKODRIVER_FILE=geckodriver-v${GECKODRIVER_VERSION}-linux64.tar.gz
5-
ARG GECKODRIVER_LINK=https://github.com/mozilla/geckodriver/releases/download/v${GECKODRIVER_VERSION}/${GECKODRIVER_FILE}
6-
73
ENV DEBIAN_FRONTEND=noninteractive
84

95
RUN apt update -y
@@ -17,9 +13,4 @@ RUN pip install -r requirements.txt
1713
RUN pip install -r requirements_testing.txt
1814
RUN rm requirements.txt requirements_testing.txt
1915

20-
# install geckodriver for selenium
21-
RUN curl -s -L $GECKODRIVER_LINK | tar -xz
22-
RUN chmod +x geckodriver
23-
RUN mv geckodriver /usr/bin/
24-
2516
ENV APLUS_BASE_URL="-"

.github/workflows/tests.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,6 @@ jobs:
4141
key: v3-${{ hashFiles('.github/workflows/Dockerfile', 'requirements_testing.txt', 'requirements.txt') }}
4242
- run: docker load -i .docker-img.tar
4343
- run: docker run -v ${{ github.workspace }}:${{ github.workspace }} -w ${{ github.workspace }} testimg bash -c 'python3 manage.py compilemessages && python3 manage.py test'
44-
selenium-tests:
45-
runs-on: ubuntu-latest
46-
needs: docker-build
47-
steps:
48-
- uses: actions/checkout@v3
49-
- uses: actions/cache@v3
50-
with:
51-
path: .docker-img.tar
52-
key: v3-${{ hashFiles('.github/workflows/Dockerfile', 'requirements_testing.txt', 'requirements.txt') }}
53-
- run: docker load -i .docker-img.tar
54-
- run: docker run -v ${{ github.workspace }}:${{ github.workspace }} -w ${{ github.workspace }} testimg bash -c 'python3 manage.py compilemessages && selenium_test/run_servers_and_tests.sh'
5544
playwright-tests:
5645
timeout-minutes: 60
5746
runs-on: ubuntu-latest

.gitignore

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ dump.json
3737

3838
test_results/
3939

40-
selenium_test/aplus.out
41-
selenium_test/example_grader.out
42-
selenium_test/server.ports
43-
selenium_test/grader/db.sqlite3
44-
4540
*~
4641
*.swp
4742
*.swo

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The [doc/GRADERS.md](doc/GRADERS.md) describes the assessment protocol supported
2828
Additionally, there is a minimal example grader in [doc/example_grader.py](doc/example_grader.py), which can be used to start a new service.
2929
A list of existing assessment services and other tools can be found in [the project github page](https://apluslms.github.io/components/).
3030

31-
The [selenium_test/](selenium_test) offers an integration test suite using the Selenium Firefox driver.
31+
The [e2e_tests/](e2e_tests) folder offers an integration test suite using Playwright.
3232

3333
Code Organization
3434
-----------------

doc/README.md

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,6 @@ Therefore they are run and updated outside the containers, within a virtual envi
139139

140140
### Prerequisities
141141

142-
- For Selenium tests:
143-
* Firefox browser installed
144-
* xvfb virtual framebuffer installed (`sudo apt-get install xvfb` or `aptdcon --install xvfb`)
145142
- python3 installed
146143
- [Python module venv (or virtualenv)](https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/#installing-virtualenv) installed
147144
- For translations: gettext (`aptdcon --install gettext` or `sudo apt-get install gettext`)
@@ -193,44 +190,6 @@ If you need to be able to login or use the admin-page while running the code wit
193190
$ python3 manage.py test
194191
```
195192

196-
### Selenium integration tests
197-
198-
Selenium tests check end-to-end -functioning from a user-perspective.
199-
The tests will automatically open and direct Firefox browser windows.
200-
Currently, the tests depend on a Unix type shell and are run within a virtual environment created above.
201-
202-
1. Install the necessary requirements:
203-
204-
```sh
205-
$ pip3 install -r requirements_testing.txt
206-
```
207-
208-
2. Download the latest release of geckodriver (choose the appropriate tar.gz file based on your machine) from https://github.com/mozilla/geckodriver/releases and extract it.
209-
210-
3. Check the path to your extracted geckodriver and add it to PATH:
211-
212-
```sh
213-
$ export PATH=$PATH:/path-to-your-extracted-geckodriver/
214-
```
215-
216-
4. To setup the servers and run all the tests at one go:
217-
218-
```sh
219-
$ selenium_test/run_servers_and_tests.sh
220-
```
221-
222-
5. Alternatively you can run individual tests:
223-
224-
```sh
225-
$ cd selenium_test/test/
226-
$ ../run_servers.sh
227-
228-
$ python3 login_test.py
229-
$ python3 home_page_test.py
230-
231-
$ ../kill_servers.sh
232-
```
233-
234193
### Updating translations for Finnish and English versions
235194

236195
Before creating a pull request, you need to ensure that the [English strings](https://github.com/apluslms/a-plus/blob/master/locale/en/LC_MESSAGES/django.po) and [Finnish translations](https://github.com/apluslms/a-plus/blob/master/locale/fi/LC_MESSAGES/django.po) are up-to-date.

requirements_testing.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Usage: pip install -r requirements.txt
22
coverage
33
# Required to run browser tests:
4-
selenium
54
pyvirtualdisplay
65
django-debug-toolbar >= 6.1.0, < 7
76
prospector

0 commit comments

Comments
 (0)