Skip to content

Added new Playwright tests to replace the old Selenium tests#1514

Merged
ihalaij1 merged 1 commit into
apluslms:masterfrom
reppuli92:reppuli92
Apr 2, 2026
Merged

Added new Playwright tests to replace the old Selenium tests#1514
ihalaij1 merged 1 commit into
apluslms:masterfrom
reppuli92:reppuli92

Conversation

@reppuli92
Copy link
Copy Markdown
Contributor

Description

What?

Created 9 new Playwright tests to replace the old Selenium e2e tests. Also edited one existing test so that it passes in the test suite regardless of other tests being run

Why?

To increase e2e testing coverage

How?

Creating new tests with the Playwright framework

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

I ran the new and improved e2e test suite in addition to all other tests in the A+ repo and verified they passed

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@ihalaij1
Copy link
Copy Markdown
Contributor

Do you think the old Selenium tests can now be removed?
Is this a complete replacement for those?

@ihalaij1 ihalaij1 self-requested a review March 30, 2026 08:08
Copy link
Copy Markdown
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just had two questions.

Copy link
Copy Markdown
Contributor

@ihalaij1 ihalaij1 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the example Playwright test test_example.py be removed now? This seems seems like a replacement for that.

Copy link
Copy Markdown
Contributor Author

@reppuli92 reppuli92 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can be removed as well, the test is basically covered by this (and test_login)

@reppuli92
Copy link
Copy Markdown
Contributor Author

Do you think the old Selenium tests can now be removed? Is this a complete replacement for those?

Yes, they can be removed now, as these should have the same test coverage as those :) should I remove them and add that change to this pull request?

@reppuli92 reppuli92 requested a review from ihalaij1 March 30, 2026 08:18
@ihalaij1
Copy link
Copy Markdown
Contributor

Sure, you can remove the old Selenium tests in this PR too.

@ihalaij1
Copy link
Copy Markdown
Contributor

Could you also make sure that all references to the old Selenium tests outside the selenium_test directory are removed from the repository?

@reppuli92
Copy link
Copy Markdown
Contributor Author

@ihalaij1 removed test_example.py and edited a couple other tests to make them more robust. Squashed the commit history to make it look cleaner, this PR is probably now ready at last :)

Copy link
Copy Markdown
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@ihalaij1 ihalaij1 merged commit 5131ded into apluslms:master Apr 2, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in A+ sprints Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants