Added new Playwright tests to replace the old Selenium tests#1514
Conversation
|
Do you think the old Selenium tests can now be removed? |
ihalaij1
left a comment
There was a problem hiding this comment.
Nice, I just had two questions.
There was a problem hiding this comment.
Can the example Playwright test test_example.py be removed now? This seems seems like a replacement for that.
There was a problem hiding this comment.
I guess it can be removed as well, the test is basically covered by this (and test_login)
Yes, they can be removed now, as these should have the same test coverage as those :) should I remove them and add that change to this pull request? |
|
Sure, you can remove the old Selenium tests in this PR too. |
|
Could you also make sure that all references to the old Selenium tests outside the |
|
@ihalaij1 removed test_example.py and edited a couple other tests to make them more robust. Squashed the commit history to make it look cleaner, this PR is probably now ready at last :) |
Description
What?
Created 9 new Playwright tests to replace the old Selenium e2e tests. Also edited one existing test so that it passes in the test suite regardless of other tests being run
Why?
To increase e2e testing coverage
How?
Creating new tests with the Playwright framework
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
I ran the new and improved e2e test suite in addition to all other tests in the A+ repo and verified they passed
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!