Skip to content

Commit 0bed5fa

Browse files
murhum1ihalaij1
authored andcommitted
Improve UX when submitting feedback
Show a "feedback received" alert and hide the Submit button after submission to signal students that their feedback has been received and they can move on. Fixes #122
1 parent 82bea9d commit 0bed5fa

2 files changed

Lines changed: 15 additions & 0 deletions

File tree

feedback/locale/fi/LC_MESSAGES/django.po

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -842,6 +842,10 @@ msgstr "näytä lisää"
842842
msgid "This feedback has unsaved changes!"
843843
msgstr "Palautteessa on tallentamattomia muutoksia!"
844844

845+
#: feedback/templates_j2/feedback/_form.html
846+
msgid "Feedback received."
847+
msgstr "Palaute vastaanotettu."
848+
845849
#: feedback/templates_j2/feedback/_form.html
846850
msgid "Submit"
847851
msgstr "Lähetä"

feedback/templates_j2/feedback/_form.html

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,10 @@
164164
{{ _("This feedback has unsaved changes!") }}
165165
</div>
166166

167+
<div id="feedback-received-message" class="alert alert-info mb-0" style="display: none">
168+
{{ _("Feedback received.") }}
169+
</div>
170+
167171
<div>
168172
<div class="btn-toolbar gap-2">
169173
<input
@@ -182,6 +186,13 @@
182186
<script>
183187
(function($) {
184188
const f = $('#{{ form_id }}');
189+
// implement feedback received notification
190+
// needs to be only shown when feedback has just been sent by student
191+
const feedbackJustReceived = f.closest('.exercise-response').data('aplus-grader-feedback-just-received');
192+
if (feedbackJustReceived) {
193+
$('#feedback-received-message').show();
194+
f.find("input[type=submit]").hide();
195+
}
185196
// implement show more
186197
const c = f.find('.history-well'), m = c.find('.show-more');
187198
m.click(function() { c.find('li.initially-hidden').removeClass('initially-hidden').show(); m.hide(); });

0 commit comments

Comments
 (0)