Skip to content

Commit a883149

Browse files
committed
Improve UX when submitting feedback
Show a "feedback received" alert and hide the Submit button after submission to signal students that their feedback has been received and they can move on. Fixes #122
1 parent 32b2590 commit a883149

2 files changed

Lines changed: 23 additions & 11 deletions

File tree

feedback/locale/fi/LC_MESSAGES/django.po

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -842,6 +842,10 @@ msgstr "näytä lisää"
842842
msgid "This feedback has unsaved changes!"
843843
msgstr "Palautteessa on tallentamattomia muutoksia!"
844844

845+
#: feedback/templates_j2/feedback/_form.html
846+
msgid "Feedback received."
847+
msgstr "Palaute vastaanotettu."
848+
845849
#: feedback/templates_j2/feedback/_form.html
846850
msgid "Submit"
847851
msgstr "Lähetä"

feedback/templates_j2/feedback/_form.html

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -164,24 +164,32 @@
164164
{{ _("This feedback has unsaved changes!") }}
165165
</div>
166166

167-
<div>
168-
<div class="btn-toolbar gap-2">
169-
<input
170-
type="submit"
171-
value="{{ _('Submit') }}"
172-
class="btn btn-primary aplus-submit mr-2">
173-
<input
174-
type="reset"
175-
value="{{ _('Reset changes') }}"
176-
class="btn btn-danger only-when-edited">
177-
</div>
167+
<div id="feedback-received-message" class="alert alert-info" style="display: none">
168+
{{ _("Feedback received.") }}
169+
</div>
170+
171+
<div class="btn-toolbar gap-2">
172+
<input
173+
type="submit"
174+
value="{{ _('Submit') }}"
175+
class="btn btn-primary aplus-submit mr-2">
176+
<input
177+
type="reset"
178+
value="{{ _('Reset changes') }}"
179+
class="btn btn-danger only-when-edited">
178180
</div>
179181
</form>
180182

181183
{# UI interaction #}
182184
<script>
183185
(function($) {
184186
const f = $('#{{ form_id }}');
187+
// implement feedback received notification
188+
// needs to be only shown when feedback has just been sent by student
189+
const feedbackJustReceived = f.closest('.exercise-response').data('aplus-grader-feedback-just-received');
190+
if (feedbackJustReceived) {
191+
$('#feedback-received-message').show();
192+
}
185193
// implement show more
186194
const c = f.find('.history-well'), m = c.find('.show-more');
187195
m.click(function() { c.find('li.initially-hidden').removeClass('initially-hidden').show(); m.hide(); });

0 commit comments

Comments
 (0)