Change how service requests A+ to show notifications#136
Merged
Conversation
Changed the behavior of sending notifications to students when editing feedback messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What?
Changed the behavior of sending notifications to students when editing feedback messages. Now emptying an existing feedback message removes existing notifications, changing an empty feedback message to a non-empty one creates a notification, and editing a non-empty feedback message to another non-empty ones preserves the notification status in A+ e.g. if a student has read the notification already, they won't get a new notification of the edited message, and if they haven't, the notification is not removed.
Why?
Requested by teachers.
Fixes #126 and #127, requires apluslms/a-plus#1500 on the A+ side.
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Tried out varying cases of editing feedback messages.