Skip to content

Change how service requests A+ to show notifications #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihalaij1 merged 1 commit into from
Feb 4, 2026
Merged

Change how service requests A+ to show notifications #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion feedback/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,12 @@ def get_notify(self):
old_msg = "".join(old_msg.split())
new_msg = self.cleaned_data['response_msg'] or ''
new_msg = "".join(new_msg.split())
return Feedback.NOTIFY.NORMAL if old_msg != new_msg else Feedback.NOTIFY.NO
if new_msg == '': # empty message always removes notification
return Feedback.NOTIFY.REMOVE
elif old_msg == '' and new_msg != '': # empty to non-empty sends notification
return Feedback.NOTIFY.NORMAL
else:
return Feedback.NOTIFY.NO # editing non-empty message does not change notification status
# FIXME: add support for instance.NOTIFY.IMPORTANT

def save(self): # pylint: disable=arguments-differ
Expand Down
2 changes: 2 additions & 0 deletions feedback/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,10 @@ class Meta:
('NO', 0, _('No notification')),
('NORMAL', 1, _('Normal notification')),
('IMPORTANT', 2, _('Important notification')),
('REMOVE', 10, _('Remove notification')),
)
NOTIFY_APLUS = {
NOTIFY.REMOVE: 'remove',
NOTIFY.NORMAL: 'normal',
NOTIFY.IMPORTANT: 'important',
}
Expand Down