Skip to content

Commit 40f1b48

Browse files
authored
Only set priority on first layer for Safari and Chrome (livekit#750)
* only set priority on Firefox * set priority only for the first layer * Create wild-news-teach.md
1 parent 72648b3 commit 40f1b48

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

.changeset/wild-news-teach.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"livekit-client": patch
3+
---
4+
5+
Only set priority on Firefox

src/room/participant/publishUtils.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import type {
1010
VideoCodec,
1111
VideoEncoding,
1212
} from '../track/options';
13-
import { getReactNativeOs, isReactNative, isSVCCodec } from '../utils';
13+
import { getReactNativeOs, isFireFox, isReactNative, isSVCCodec } from '../utils';
1414

1515
/** @internal */
1616
export function mediaTrackToLocalTrack(
@@ -118,6 +118,7 @@ export function computeVideoEncodings(
118118
height,
119119
videoEncoding.maxBitrate,
120120
videoEncoding.maxFramerate,
121+
videoEncoding.priority,
121122
);
122123

123124
if (scalabilityMode && isSVCCodec(videoCodec)) {
@@ -311,7 +312,8 @@ function encodingsFromPresets(
311312
if (preset.encoding.maxFramerate) {
312313
encoding.maxFramerate = preset.encoding.maxFramerate;
313314
}
314-
if (preset.encoding.priority) {
315+
const canSetPriority = isFireFox() || idx === 0;
316+
if (preset.encoding.priority && canSetPriority) {
315317
encoding.priority = preset.encoding.priority;
316318
encoding.networkPriority = preset.encoding.priority;
317319
}

0 commit comments

Comments
 (0)