volumes_from

Author: apocas

lib/services.js

@@ -10,7 +10,7 @@ module.exports = async function (docker, projectName, recipe, output) {
     var opts = {
       'name': projectName + '_' + serviceName,
       'Image': service.image,
-      'HostConfig': buildHostConfig(service),
+      'HostConfig': buildHostConfig(service, recipe),
       'Env': buildEnvVars(service),
       'NetworkingConfig': {
         'EndpointsConfig': {
@@ -80,20 +80,18 @@ module.exports = async function (docker, projectName, recipe, output) {
       };
     }
 
-    if (service.volumes) {
-      opts['Volumes'] = {};
-      for (var volume of service.volumes) {
-        if (typeof volume === 'string' || volume instanceof String) {
-          var v = volume.split(':');
-          opts['Volumes'][v[1]] = {};
-        } else {
-          if (volume.target) {
-            opts['Volumes'][volume.target] = {};
-          }
-        }
+    if (service.volumes_from) {
+      for (var volume_from of service.volumes_from) {
+        var vf = volume_from.split(':');
+        var svf = recipe.services[vf[0]];
+        buildVolumes(svf.volumes, opts);
       }
     }
 
+    if (service.volumes) {
+      buildVolumes(service.volumes, opts);
+    }
+
     if (service.name !== undefined) {
       opts.Name = serviceName;
     }
@@ -122,37 +120,23 @@ module.exports = async function (docker, projectName, recipe, output) {
 }
 
 //ToDo: complete the compose specification
-var buildHostConfig = function (service) {
+var buildHostConfig = function (service, recipe) {
   var output = {
     'RestartPolicy': { 'Name': service.restart }
   };
 
-  if (service.volumes) {
-    output['Binds'] = [];
-
-    for (var volume of service.volumes) {
-      if (typeof volume === 'string' || volume instanceof String) {
-        output['Binds'].push(volume);
-      } else {
-        var volumestr = '';
-        if (volume.source && volume.target) {
-          volumestr += volume.source + ':' + volume.target + ':';
-        }
-        if (volume.read_only) {
-          volumestr += 'ro,';
-        }
-        if (volume.volume && volume.volume.nocopy) {
-          volumestr += 'nocopy,';
-        }
-        if (volume.bind && volume.bind.propagation) {
-          volumestr += volume.bind.propagation + ',';
-        }
-        volumestr = volumestr.slice(0, -1);
-        output['Binds'].push(volumestr);
-      }
+  if (service.volumes_from) {
+    for (var volume_from of service.volumes_from) {
+      var vf = volume_from.split(':');
+      var svf = recipe.services[vf[0]];
+      buildVolumesHostconfig(svf.volumes, output, vf[1]);
     }
   }
 
+  if (service.volumes) {
+    buildVolumesHostconfig(service.volumes, output);
+  }
+
   if (service.ports && service.ports.length > 0) {
     var ports = {};
     for (var portb of service.ports) {
@@ -165,6 +149,53 @@ var buildHostConfig = function (service) {
   return output;
 }
 
+var buildVolumesHostconfig = function (volumes, output, type) {
+  if (output['Binds'] === undefined) {
+    output['Binds'] = [];
+  }
+  for (var volume of volumes) {
+    if (typeof volume === 'string' || volume instanceof String) {
+      var aux = volume;
+      if (type == 'ro') {
+        aux += ':ro'
+      }
+      output['Binds'].push(aux);
+    } else {
+      var volumestr = '';
+      if (volume.source && volume.target) {
+        volumestr += volume.source + ':' + volume.target + ':';
+      }
+      if (volume.read_only || type == 'ro') {
+        volumestr += 'ro,';
+      }
+      if (volume.volume && volume.volume.nocopy) {
+        volumestr += 'nocopy,';
+      }
+      if (volume.bind && volume.bind.propagation) {
+        volumestr += volume.bind.propagation + ',';
+      }
+      volumestr = volumestr.slice(0, -1);
+      output['Binds'].push(volumestr);
+    }
+  }
+}
+
+var buildVolumes = function (volumes, opts) {
+  if (opts['Volumes'] === undefined) {
+    opts['Volumes'] = {};
+  }
+  for (var volume of volumes) {
+    if (typeof volume === 'string' || volume instanceof String) {
+      var v = volume.split(':');
+      opts['Volumes'][v[1]] = {};
+    } else {
+      if (volume.target) {
+        opts['Volumes'][volume.target] = {};
+      }
+    }
+  }
+}
+
 var buildEnvVars = function (service) {
   var output = [];
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "dockerode-compose",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "docker-compose in nodejs using dockerode",
   "main": "./compose.js",
   "scripts": {

package.json

@@ -19,6 +19,8 @@ services:
     ports:
       - "8000:80"
     restart: always
+    volumes_from:
+      - db:ro
     environment:
       WORDPRESS_DB_HOST: db:3306
       WORDPRESS_DB_USER: wordpress