Skip to content

fix: ConfigService.getConfig(appId, namespace) returns wrong app's config #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shawyeok wants to merge 3 commits into
base: main
Choose a base branch
from
+42 −1

Revert "test: fix race condition in SpringAnnotationCompatibilityTest"

f6110d1
Select commit
Loading
Failed to load commit list.
Open

fix: ConfigService.getConfig(appId, namespace) returns wrong app's config #140

Revert "test: fix race condition in SpringAnnotationCompatibilityTest"
f6110d1
Select commit
Loading
Failed to load commit list.
Mergify / Mergify Merge Queue completed Jun 9, 2026 in 0s

Waiting for queue conditions to match

Queue entry conditions

  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule multi-commit]:
      • #approved-reviews-by >= 1
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • github-review-decision = APPROVED [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0
      • #commits > 1
      • -closed
      • -conflict
      • -draft
      • base = main
      • check-success = CLAssistant
      • check-success = compat-api
      • check-success = compat-spring-boot-spring-boot-2.7-jdk8
      • check-success = compat-spring-boot-spring-boot-3.3-jdk17
      • check-success = compat-spring-boot-spring-boot-4.0-jdk17
      • check-success = compat-spring-spring-3.1.1-jdk8
      • check-success = compat-spring-spring-6.1-jdk17
      • check-success = compile-matrix (11)
      • check-success = compile-matrix (17)
      • check-success = compile-matrix (8)
      • check-success = license
      • check-success = unit-integration-pr
      • any of [🛡 GitHub branch protection]:
        • check-success = license
        • check-neutral = license
        • check-skipped = license
      • any of [🛡 GitHub branch protection]:
        • check-success = CLAssistant
        • check-neutral = CLAssistant
        • check-skipped = CLAssistant
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-api
        • check-neutral = compat-api
        • check-skipped = compat-api
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-boot-spring-boot-2.7-jdk8
        • check-neutral = compat-spring-boot-spring-boot-2.7-jdk8
        • check-skipped = compat-spring-boot-spring-boot-2.7-jdk8
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-boot-spring-boot-3.3-jdk17
        • check-neutral = compat-spring-boot-spring-boot-3.3-jdk17
        • check-skipped = compat-spring-boot-spring-boot-3.3-jdk17
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-boot-spring-boot-4.0-jdk17
        • check-neutral = compat-spring-boot-spring-boot-4.0-jdk17
        • check-skipped = compat-spring-boot-spring-boot-4.0-jdk17
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-spring-3.1.1-jdk8
        • check-neutral = compat-spring-spring-3.1.1-jdk8
        • check-skipped = compat-spring-spring-3.1.1-jdk8
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-spring-6.1-jdk17
        • check-neutral = compat-spring-spring-6.1-jdk17
        • check-skipped = compat-spring-spring-6.1-jdk17
      • any of [🛡 GitHub branch protection]:
        • check-success = compile-matrix (17)
        • check-neutral = compile-matrix (17)
        • check-skipped = compile-matrix (17)
      • any of [🛡 GitHub branch protection]:
        • check-success = compile-matrix (11)
        • check-neutral = compile-matrix (11)
        • check-skipped = compile-matrix (11)
      • any of [🛡 GitHub branch protection]:
        • check-success = compile-matrix (8)
        • check-neutral = compile-matrix (8)
        • check-skipped = compile-matrix (8)
      • any of [🛡 GitHub branch protection]:
        • check-success = unit-integration-pr
        • check-neutral = unit-integration-pr
        • check-skipped = unit-integration-pr
    • all of [📌 queue conditions of queue rule single-commit]:
      • #approved-reviews-by >= 1
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #commits = 1
      • github-review-decision = APPROVED [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0
      • -closed
      • -conflict
      • -draft
      • base = main
      • check-success = CLAssistant
      • check-success = compat-api
      • check-success = compat-spring-boot-spring-boot-2.7-jdk8
      • check-success = compat-spring-boot-spring-boot-3.3-jdk17
      • check-success = compat-spring-boot-spring-boot-4.0-jdk17
      • check-success = compat-spring-spring-3.1.1-jdk8
      • check-success = compat-spring-spring-6.1-jdk17
      • check-success = compile-matrix (11)
      • check-success = compile-matrix (17)
      • check-success = compile-matrix (8)
      • check-success = license
      • check-success = unit-integration-pr
      • any of [🛡 GitHub branch protection]:
        • check-success = license
        • check-neutral = license
        • check-skipped = license
      • any of [🛡 GitHub branch protection]:
        • check-success = CLAssistant
        • check-neutral = CLAssistant
        • check-skipped = CLAssistant
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-api
        • check-neutral = compat-api
        • check-skipped = compat-api
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-boot-spring-boot-2.7-jdk8
        • check-neutral = compat-spring-boot-spring-boot-2.7-jdk8
        • check-skipped = compat-spring-boot-spring-boot-2.7-jdk8
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-boot-spring-boot-3.3-jdk17
        • check-neutral = compat-spring-boot-spring-boot-3.3-jdk17
        • check-skipped = compat-spring-boot-spring-boot-3.3-jdk17
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-boot-spring-boot-4.0-jdk17
        • check-neutral = compat-spring-boot-spring-boot-4.0-jdk17
        • check-skipped = compat-spring-boot-spring-boot-4.0-jdk17
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-spring-3.1.1-jdk8
        • check-neutral = compat-spring-spring-3.1.1-jdk8
        • check-skipped = compat-spring-spring-3.1.1-jdk8
      • any of [🛡 GitHub branch protection]:
        • check-success = compat-spring-spring-6.1-jdk17
        • check-neutral = compat-spring-spring-6.1-jdk17
        • check-skipped = compat-spring-spring-6.1-jdk17
      • any of [🛡 GitHub branch protection]:
        • check-success = compile-matrix (17)
        • check-neutral = compile-matrix (17)
        • check-skipped = compile-matrix (17)
      • any of [🛡 GitHub branch protection]:
        • check-success = compile-matrix (11)
        • check-neutral = compile-matrix (11)
        • check-skipped = compile-matrix (11)
      • any of [🛡 GitHub branch protection]:
        • check-success = compile-matrix (8)
        • check-neutral = compile-matrix (8)
        • check-skipped = compile-matrix (8)
      • any of [🛡 GitHub branch protection]:
        • check-success = unit-integration-pr
        • check-neutral = unit-integration-pr
        • check-skipped = unit-integration-pr
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [📌 queue requirement]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

All conditions must match for automatic queuing. You can also use @Mergifyio queue to queue manually.

View more details on Mergify