feat: show deprecation warning for all commands, not just service:*#2695
Open
dotdat wants to merge 1 commit into
Open
feat: show deprecation warning for all commands, not just service:*#2695dotdat wants to merge 1 commit into
dotdat wants to merge 1 commit into
Conversation
Previously only service:* commands called printDeprecationWarning() in their individual run() methods. client:* commands (client:check, client:push, client:codegen, etc.) showed no deprecation notice at all. This moves the call into ProjectCommand.init(), which is the oclif lifecycle hook that runs before every command's run() method, ensuring all subcommands emit the warning. A _deprecationWarningPrinted guard makes the method idempotent so service:* commands that still call it explicitly in run() don't double-print. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 2b3af51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client:*commands (e.g.client:check,client:push,client:codegen) previously showed no deprecation warning at allprintDeprecationWarning()intoProjectCommand.init()so every command emits the warning automatically_deprecationWarningPrintedguard to make the method idempotent, preventingservice:*commands (which still call it explicitly inrun()) from double-printingpatchbump on theapollopackageTest plan
client:*command (e.g.apollo client:check --help) — deprecation warning should appear on stderrservice:*command (e.g.apollo service:check --help) — deprecation warning should appear exactly once