Add tests validating minimum join spec version given subgraph federation version#3110
Open
trevor-scheer wants to merge 3 commits into
Open
Add tests validating minimum join spec version given subgraph federation version#3110trevor-scheer wants to merge 3 commits into
trevor-scheer wants to merge 3 commits into
Conversation
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
trevor-scheer
changed the title
join spec version for subgraphs using federation v2.0->2.2 inclusive
trevor-scheer
force-pushed
the
trevor/min-spec-versions-test
branch
from
3c34627 to
af710b9
Compare
trevor-scheer
changed the title
join spec version for subgraphs using federation v2.0->2.2 inclusive
trevor-scheer
force-pushed
the
trevor/min-spec-versions-test
branch
from
af710b9 to
5384448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test each federation version -> join version is as expected. Add some context about why fed v2.0 uses join v0.3 instead of join v0.2.