Update context-matching logic to use earlier path edges if possible#3114
Draft
sachindshinde wants to merge 1 commit into
Draft
Update context-matching logic to use earlier path edges if possible#3114sachindshinde wants to merge 1 commit into
sachindshinde wants to merge 1 commit into
Conversation
…tions prior to the match location, we shift the location earlier accordingly.
|
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates context-matching logic for
@context/@fromContextto use earlier edges in theGraphPathif possible. (Also a bit of logic reorganizing for performance reasons.)Specifically, if there are key resolution or root-type resolution edges prior to the match point in the graph path, then the context can be resolved at those edges to potentially generate more optimal query plans. (This should have occurred with the
handleRequireslogic being reapplied to contexts, but it wasn't happening for some reason.)