fix(composition): pass subgraph name instead of field name to isMergedDirective#3445
Open
dariuszkuc wants to merge 5 commits into
Open
fix(composition): pass subgraph name instead of field name to isMergedDirective#3445dariuszkuc wants to merge 5 commits into
isMergedDirective#3445dariuszkuc wants to merge 5 commits into
Conversation
Update the link on the Federation v2.12 changelog entry to point directly to the Connectors 0.3 section of the connectors changelog, rather than the top of the changelog page. This addresses customer confusion about where to find details on what changed in Connector spec v0.3.
…3427) ## Summary - The Federation v2.12 changelog entry states "Federation v2.12 is a prerequisite for the Connector specification version 0.3" with a "Learn more." link - Previously the link pointed to the top of the connectors changelog page (`/graphos/connectors/reference/changelog`), which doesn't directly surface what changed in Connectors 0.3 - Updated the link to include the anchor `#connectors-03--federation-2120`, pointing users directly to the Connectors 0.3 section ## Why this change A State Farm customer reported confusion: the "Learn more." link didn't explain what was actually in the Connectors v0.3 update. Adding the anchor makes the link land directly on the relevant changelog section, immediately answering the customer's question. ## Acceptance criteria - [ ] "Learn more." link in the v2.12 section of `docs/source/schema-design/federated-schemas/reference/versions.mdx` points to `/graphos/connectors/reference/changelog#connectors-03--federation-2120` - [ ] The v2.13 link (for Connectors 0.4) is unchanged ## Jira ticket https://apollographql.atlassian.net/browse/DXM-483 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Fed 2.14 changeset docs update
…edDirective` `validateAndFilterExternal` was passing `source.name` (the field name) instead of `this.names[i]` (the subgraph name) to `isMergedDirective`. This caused `shouldComposeDirective` to miss `@composeDirective`-composed directives on external fields, since it looked up the directive under a nonexistent subgraph name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 59cb389818b60b069f15afd1 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
🦋 Changeset detectedLatest commit: e0ca031 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateAndFilterExternalwas passingsource.name(the field name) instead ofthis.names[i](the subgraph name) toisMergedDirective. This causedshouldComposeDirectiveto miss@composeDirective-composed directives on external fields, since it looked up the directive under a nonexistent subgraph name.