refactor: standardize date objects across project#472
Open
akselmat wants to merge 1 commit into
Open
Conversation
Switch period/applicant/committee date fields from string to BSON Date end-to-end. Adds parseDates helpers for client-side conversion, migration scripts (in-place and aggregation-based), and fixes the formatter, validator, and schedule-rendering paths that broke when the types flipped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jorgengaldal
requested changes
Apr 30, 2026
| start: new Date(at.start).toISOString(), | ||
| end: new Date(at.end).toISOString(), | ||
| start: at.start instanceof Date ? at.start.toISOString() : at.start, | ||
| end: at.end instanceof Date ? at.end.toISOString() : at.end, |
Collaborator
There was a problem hiding this comment.
Hvorfor trengs denne sjekken her? Vil jo helst at den alltid skal være instanceof Date
| weekDates[date].push({ start: slot.start, end: slot.end }); | ||
| if (slot?.start && slot?.end) { | ||
| const start = new Date(slot.start as unknown as string | number | Date); | ||
| const end = new Date(slot.end as unknown as string | number | Date); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch period/applicant/committee date fields from string to BSON Date end-to-end. Adds parseDates helpers for client-side conversion, migration scripts (in-place and aggregation-based), and fixes the formatter, validator, and schedule-rendering paths that broke when the types flipped.