Skip to content

Commit 4f210fb

Browse files
authored
Merge pull request #79 from appbaseio/fix/patch-response
fix: consistent response for PATCH endpoints
2 parents 018e749 + caf5192 commit 4f210fb

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

plugins/permissions/handlers.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,9 @@ func (p *permissions) patchPermission() http.HandlerFunc {
230230
}
231231
}
232232

233-
raw, err := p.es.patchPermission(req.Context(), username, patch)
234-
if err == nil {
235-
util.WriteBackRaw(w, raw, http.StatusOK)
233+
_, err2 := p.es.patchPermission(req.Context(), username, patch)
234+
if err2 == nil {
235+
util.WriteBackMessage(w, "Permission is updated successfully", http.StatusOK)
236236
return
237237
}
238238

plugins/users/handlers.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,9 @@ func (u *Users) patchUser() http.HandlerFunc {
210210
}
211211
}
212212

213-
raw, err := u.es.patchUser(req.Context(), username, patch)
214-
if err == nil {
215-
util.WriteBackRaw(w, raw, http.StatusOK)
213+
_, err2 := u.es.patchUser(req.Context(), username, patch)
214+
if err2 == nil {
215+
util.WriteBackMessage(w, "User is updated successfully", http.StatusOK)
216216
return
217217
}
218218

@@ -281,9 +281,9 @@ func (u *Users) patchUserWithUsername() http.HandlerFunc {
281281
}
282282
}
283283

284-
raw, err := u.es.patchUser(req.Context(), username, patch)
285-
if err == nil {
286-
util.WriteBackRaw(w, raw, http.StatusOK)
284+
_, err2 := u.es.patchUser(req.Context(), username, patch)
285+
if err2 == nil {
286+
util.WriteBackMessage(w, "User is updated successfully", http.StatusOK)
287287
return
288288
}
289289

0 commit comments

Comments
 (0)