fix: prevent ErrorBoundary onError from spamming null callbacks on every update#2318
Open
AshayK003 wants to merge 1 commit into
Open
fix: prevent ErrorBoundary onError from spamming null callbacks on every update#2318AshayK003 wants to merge 1 commit into
AshayK003 wants to merge 1 commit into
Conversation
…ery update The componentDidUpdate method unconditionally called invokeErrorCallback(), which fired this.props.onError(null, componentId) on every re-render even when no error was present. This caused unnecessary null-error notifications in consumer error monitoring. Added a guard so invokeErrorCallback is only called when this.state.error is truthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
componentDidUpdatemethod in ErrorBoundary unconditionally calledinvokeErrorCallback(), which firesthis.props.onError(null, componentId)on every re-render — even when no error exists. This spams consumer error monitoring with null-error notifications on every component update.Root Cause
Fix
Guard
invokeErrorCallback()behindthis.state.error, so it only fires when an actual error exists in state:Testing
Snapshot test already exists. The render output is unchanged — only the callback invocation path is gated. No visual regression.