Enable GitHub Actions CI#12
Merged
Merged
Conversation
|
🤖 Supernova Code Review — View trace |
b110b19 to
7725240
Compare
Drop the Codecov and RubyGems.org publish steps since this fork won't configure those secrets, and remove the Pages-only docs workflow since GitHub Pages isn't being enabled either. Also pin rdoc below 8, since rdoc 8.0 pulls in rbs (a transitive dep of irb, via railties) whose native extension doesn't build on JRuby, breaking bundle install on that leg of the test matrix. This was already latent since Actions had never actually run before now. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
7725240 to
f70cdd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Actions had been disabled org-wide on this repo, so the CI workflows already checked into
.github/workflows/had never actually run. Now that Actions is enabled:RUBYGEMS_AUTH_TOKENpublish step from_test-matrix.yml/release.yml— this fork isn't configuring either secret. The GitHub Packages publish step stays; it authenticates with the built-inGITHUB_TOKEN..github/workflows/docs.yml— it's entirely GitHub Pages-dependent (the build job'sconfigure-pagesstep 404s without Pages enabled), and Pages isn't being enabled either.rdocbelow 8 in theGemfile.rdoc 8.0pulls inrbs(transitively, viairb→railties), whose native C extension doesn't build on JRuby — this brokebundle installon that leg of the test matrix the first time CI actually ran. Dev-only pin, no runtime impact.Test plan
bundle exec rubocop— clean, repo-widebundle exec rspec— full suite green (1633 examples, 0 failures)🤖 Generated with Claude Code