Skip to content

Commit 7964ef4

Browse files
authored
Merge pull request #209 from ddxv/main
Small fix for publisher apps' metrics
2 parents a19aa38 + de8ca19 commit 7964ef4

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

frontend/src/lib/CompaniesOverviewTable.svelte

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,15 @@
7171
7272
// Metric state — declared after view-mode derivations since dataMetric depends on showsApiColumns
7373
let rawMetric = $state<MetricValue>('market_share');
74-
let dataMetric = $derived(showsApiColumns ? 'app_count' : rawMetric);
74+
let dataMetric = $derived(rawMetric);
75+
76+
$effect(() => {
77+
// App-publishers view only supports app_count and installs metrics,
78+
// so snap any unsupported selection (e.g. market_share) back to app_count.
79+
if (showsApiColumns && rawMetric !== 'app_count' && rawMetric !== 'installs') {
80+
rawMetric = 'app_count';
81+
}
82+
});
7583
7684
// ===== Dynamic column definitions =====
7785
let columns = $derived.by<ReturnType<typeof genericColumns>>(() => {

frontend/src/routes/about/+page.svelte

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,13 @@
158158
</div>
159159
</div>
160160

161+
<div class="card preset-filled-surface-100-900 {cardPadding}">
162+
<h2 class="h2 {titlePadding}">About the Founder & Architect</h2>
163+
<div class={contentPadding}>
164+
<p>AppGoblin was founded and engineered by James O'Claire.</p>
165+
</div>
166+
</div>
167+
161168
<div class="card preset-filled-surface-100-900 p-2 md:p-8">
162169
<h2 class="h2 p-2 md:p-4">Community & Feedback</h2>
163170
<div class="p-2 space-y-4">
@@ -194,8 +201,9 @@
194201
</div>
195202
</a>
196203
<p>
197-
Join AppGoblin's Discord for a quick way to contact me or discuss ASO, app marketing and in
198-
app advertisements. Feel free to give feedback or request new features.
204+
Join AppGoblin's Discord to connect with the AppGoblin community or to DM me. Feel free to
205+
give feedback or request new features. You can also use the <a href="/contact">/contact</a> form
206+
for tips or to start an email conversation.
199207
</p>
200208
</div>
201209
</div>

0 commit comments

Comments
 (0)