chore: Remove the redundant check after activating the system app (#1043)

Author: mykola-mokhnach

WebDriverAgentLib/Categories/XCUIApplication+FBHelpers.m

@@ -621,23 +621,17 @@ + (BOOL)fb_switchToSystemApplicationWithError:(NSError **)error
 {
   XCUIApplication *systemApp = self.fb_systemApplication;
   @try {
-    if (!systemApp.running) {
-      [systemApp launch];
-    } else {
+    if (systemApp.running) {
       [systemApp activate];
+    } else {
+      [systemApp launch];
     }
   } @catch (NSException *e) {
     return [[[FBErrorBuilder alloc]
              withDescription:nil == e ? @"Cannot open the home screen" : e.reason]
             buildError:error];
   }
-  return [[[[FBRunLoopSpinner new]
-            timeout:5]
-           timeoutErrorMessage:@"Timeout waiting until the home screen is visible"]
-          spinUntilTrue:^BOOL{
-    return [systemApp fb_isSameAppAs:self.fb_activeApplication];
-  }
-          error:error];
+  return YES;
 }
 
 - (BOOL)fb_isSameAppAs:(nullable XCUIApplication *)otherApp

WebDriverAgentLib/Utilities/FBScreenshot.m

@@ -28,7 +28,7 @@
 
 NSString *formatTimeInterval(NSTimeInterval interval) {
   NSUInteger milliseconds = (NSUInteger)(interval * 1000);
-  return [NSString stringWithFormat:@"%ld ms", milliseconds];
+  return [NSString stringWithFormat:@"%lu ms", milliseconds];
 }
 
 @implementation FBScreenshot

WebDriverAgentTests/IntegrationTests/XCUIDeviceHelperTests.m

@@ -102,7 +102,7 @@ - (void)testGoToHomeScreen
   NSError *error;
   XCTAssertTrue([[XCUIDevice sharedDevice] fb_goToHomescreenWithError:&error]);
   XCTAssertNil(error);
-  XCTAssertTrue([XCUIApplication fb_activeApplication].icons[@"Safari"].exists);
+  FBAssertWaitTillBecomesTrue([XCUIApplication fb_activeApplication].icons[@"Safari"].exists);
 }
 
 - (void)testLockUnlockScreen