ditch bluebird

Author: mykola-mokhnach

Scripts/fetch-prebuilt-wda.mjs

@@ -4,7 +4,6 @@ import { readFileSync } from 'node:fs';
 import axios from 'axios';
 import { logger, fs, mkdirp, net } from '@appium/support';
 import _ from 'lodash';
-import B from 'bluebird';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -60,7 +59,7 @@ async function fetchPrebuiltWebDriverAgentAssets () {
   }
 
   // Wait for them all to finish
-  return await B.all(agentsDownloading);
+  return await Promise.all(agentsDownloading);
 }
 
 if (isMainModule) {

lib/utils.ts

@@ -5,7 +5,6 @@ import {fileURLToPath} from 'node:url';
 import {log} from './logger';
 import _ from 'lodash';
 import {PLATFORM_NAME_TVOS} from './constants';
-import B from 'bluebird';
 import _fs from 'node:fs';
 import {waitForCondition} from 'asyncbox';
 import {arch} from 'node:os';
@@ -90,7 +89,7 @@ export async function killAppUsingPattern(pgrepPattern: string): Promise<void> {
               return true;
             }
           });
-          return (await B.all(pidCheckPromises)).every((x) => x === true);
+          return (await Promise.all(pidCheckPromises)).every((x) => x === true);
         },
         {
           waitMs: 1000,
@@ -305,7 +304,7 @@ export async function resetTestProcesses(udid: string, isSimulator: boolean): Pr
     processPatterns.push(`xctest.*${udid}`);
   }
   log.debug(`Killing running processes '${processPatterns.join(', ')}' for the device ${udid}...`);
-  await B.all(processPatterns.map(killAppUsingPattern));
+  await Promise.all(processPatterns.map(killAppUsingPattern));
 }
 
 /**
@@ -341,19 +340,22 @@ export async function getPIDsListeningOnPort(
   if (!_.isFunction(filteringFunc)) {
     return result;
   }
-  return await B.filter(result, async (pid) => {
-    let stdout: string;
-    try {
-      ({stdout} = await exec('ps', ['-p', pid, '-o', 'command']));
-    } catch (e: any) {
-      if (e.code === 1) {
-        // The process does not exist anymore, there's nothing to filter
-        return false;
+  const filtered = await Promise.all(
+    result.map(async (pid) => {
+      let stdout: string;
+      try {
+        ({stdout} = await exec('ps', ['-p', pid, '-o', 'command']));
+      } catch (e: any) {
+        if (e.code === 1) {
+          // The process does not exist anymore, there's nothing to filter
+          return null;
+        }
+        throw e;
       }
-      throw e;
-    }
-    return await filteringFunc(stdout);
-  });
+      return (await filteringFunc(stdout)) ? pid : null;
+    }),
+  );
+  return filtered.filter((pid): pid is string => Boolean(pid));
 }
 
 // Private functions

lib/webdriveragent.ts

@@ -1,7 +1,6 @@
 import {waitForCondition} from 'asyncbox';
 import _ from 'lodash';
 import path from 'node:path';
-import B from 'bluebird';
 import {JWProxy} from '@appium/base-driver';
 import {fs, util, plist} from '@appium/support';
 import type {AppiumLogger, StringRecord} from '@appium/types';
@@ -358,7 +357,7 @@ export class WebDriverAgent {
     const existsPromises = ['Resources', `Resources${path.sep}WebDriverAgent.bundle`].map(
       (subPath) => fs.exists(path.resolve(this.bootstrapPath, subPath)),
     );
-    return (await B.all(existsPromises)).some((v) => v === false);
+    return (await Promise.all(existsPromises)).some((v) => v === false);
   }
 
   /**

lib/xcodebuild.ts

@@ -3,7 +3,6 @@ import {SubProcess, exec} from 'teen_process';
 import {logger, timing} from '@appium/support';
 import type {AppiumLogger, StringRecord} from '@appium/types';
 import {log as defaultLogger} from './logger';
-import B from 'bluebird';
 import {
   setRealDeviceSecurity,
   setXctestrunFile,
@@ -207,7 +206,7 @@ export class XcodeBuild {
 
     if (this.prebuildDelay > 0) {
       // pause a moment
-      await B.delay(this.prebuildDelay);
+      await new Promise((resolve) => setTimeout(resolve, this.prebuildDelay));
     }
   }
 
@@ -242,7 +241,7 @@ export class XcodeBuild {
       throw new Error('xcodebuild subprocess was not created');
     }
     const xcodebuild = this.xcodebuild;
-    return await new B((resolve, reject) => {
+    return await new Promise<StringRecord | void>((resolve, reject) => {
       xcodebuild.once('exit', (code, signal) => {
         xcodeLog.error(`xcodebuild exited with code '${code}' and signal '${signal}'`);
         xcodebuild.removeAllListeners();

package.json

@@ -54,16 +54,15 @@
     "@appium/types": "^1.0.0-rc.1",
     "@semantic-release/changelog": "^6.0.1",
     "@semantic-release/git": "^10.0.1",
-    "@types/bluebird": "^3.5.38",
     "@types/lodash": "^4.14.196",
     "@types/mocha": "^10.0.1",
     "@types/node": "^25.0.0",
     "appium-xcode": "^6.0.0",
     "chai": "^6.0.0",
     "chai-as-promised": "^8.0.0",
     "conventional-changelog-conventionalcommits": "^9.0.0",
-    "node-simctl": "^8.0.0",
     "mocha": "^11.0.1",
+    "node-simctl": "^8.0.0",
     "prettier": "^3.0.0",
     "semantic-release": "^25.0.2",
     "semver": "^7.3.7",
@@ -80,7 +79,6 @@
     "async-lock": "^1.0.0",
     "asyncbox": "^6.1.0",
     "axios": "^1.4.0",
-    "bluebird": "^3.5.5",
     "lodash": "^4.17.11",
     "teen_process": "^4.0.7"
   },