Address comments

Author: mykola-mokhnach

lib/webdriveragent.ts

@@ -353,10 +353,10 @@ export class WebDriverAgent {
    * @returns `true` if source is fresh (all required files exist), `false` otherwise
    */
   async isSourceFresh(): Promise<boolean> {
-    const existsPromises = ['Resources', `Resources${path.sep}WebDriverAgent.bundle`].map(
+    const existsPromises = ['Resources', path.join('Resources', 'WebDriverAgent.bundle')].map(
       (subPath) => fs.exists(path.resolve(this.bootstrapPath, subPath)),
     );
-    return (await Promise.all(existsPromises)).some((v) => v === false);
+    return (await Promise.all(existsPromises)).every((v) => v === true);
   }
 
   /**
@@ -527,14 +527,14 @@ export class WebDriverAgent {
   }
 
   private toUrl(value: string): URL {
+    // Treat values without `://` as host/path inputs and normalize to http.
+    if (!value.includes(URL_PROTOCOL_SEPARATOR)) {
+      return new URL(`http://${value}`);
+    }
     try {
       return new URL(value);
-    } catch (err) {
-      // Keep compatibility with legacy parser behavior for values like "localhost:8100".
-      if (!value.includes(URL_PROTOCOL_SEPARATOR)) {
-        return new URL(`http://${value}`);
-      }
-      throw err;
+    } catch {
+      throw new Error(`Invalid URL: ${value}`);
     }
   }
 

test/unit/webdriveragent-specs.ts

@@ -208,6 +208,24 @@ describe('WebDriverAgent', function () {
         expect(agent.noSessionProxy.scheme).to.eql('https');
       }
     });
+
+    it('should accept scheme-less webDriverAgentUrl values', function () {
+      const args = Object.assign({}, fakeConstructorArgs);
+      args.webDriverAgentUrl = 'localhost:8100/aabbccdd';
+      const agent = new WebDriverAgent(args);
+      expect(agent.url.href).to.eql('http://localhost:8100/aabbccdd');
+      (agent as any).setupProxies('mysession');
+      if (agent.jwproxy) {
+        expect(agent.jwproxy.scheme).to.eql('http');
+      }
+    });
+
+    it('should throw for invalid webDriverAgentUrl with explicit scheme', function () {
+      const args = Object.assign({}, fakeConstructorArgs);
+      args.webDriverAgentUrl = 'http://';
+      const agent = new WebDriverAgent(args);
+      expect(() => agent.url).to.throw();
+    });
   });
 
   describe('setupCaching()', function () {