fixup! feat: expose customActions on the element

Add element double declaration for custom actions in unit tests.

Author: ihor-kravchenko-evinced

WebDriverAgentLib/Categories/XCUIElement+FBCustomActions.m

@@ -10,6 +10,7 @@
 #import "XCUIElement+FBUtilities.h"
 #import "FBXCElementSnapshotWrapper+Helpers.h"
 #import "FBLogger.h"
+#import "FBConfiguration.h"
 #import "XCTestPrivateSymbols.h"
 
 @interface FBXCElementSnapshotWrapper (FBCustomActionsInternal)
@@ -88,7 +89,7 @@ - (NSString *)fb_stringAttribute:(NSString *)attributeName
       NSLog(@"[FBCustomActions] Custom action title: %@", title);
     }
 
-    NSString *joined = [stringified componentsJoinedByString:@", "];
+    NSString *joined = [stringified componentsJoinedByString:[FBConfiguration customActionsDelimiter]];
     NSMutableDictionary *updated =
       (self.additionalAttributes ?: @{}).mutableCopy;
     updated[symbol] = joined;

WebDriverAgentLib/Commands/FBSessionCommands.m

@@ -356,6 +356,7 @@ + (NSArray *)routes
       FB_SETTING_INCLUDE_NATIVE_FRAME_IN_PAGE_SOURCE: @([FBConfiguration includeNativeFrameInPageSource]),
       FB_SETTING_INCLUDE_MIN_MAX_VALUE_IN_PAGE_SOURCE: @([FBConfiguration includeMinMaxValueInPageSource]),
       FB_SETTING_INCLUDE_CUSTOM_ACTIONS_IN_PAGE_SOURCE: @([FBConfiguration includeCustomActionsInPageSource]),
+      FB_SETTING_CUSTOM_ACTIONS_DELIMITER: [FBConfiguration customActionsDelimiter],
       FB_SETTING_ENFORCE_CUSTOM_SNAPSHOTS: @([FBConfiguration enforceCustomSnapshots]),
       FB_SETTING_LIMIT_XPATH_CONTEXT_SCOPE: @([FBConfiguration limitXpathContextScope]),
 #if !TARGET_OS_TV
@@ -471,6 +472,9 @@ + (NSArray *)routes
   if (nil != [settings objectForKey:FB_SETTING_INCLUDE_CUSTOM_ACTIONS_IN_PAGE_SOURCE]) {
     [FBConfiguration setIncludeCustomActionsInPageSource:[[settings objectForKey:FB_SETTING_INCLUDE_CUSTOM_ACTIONS_IN_PAGE_SOURCE] boolValue]];
   }
+  if (nil != [settings objectForKey:FB_SETTING_CUSTOM_ACTIONS_DELIMITER]) {
+    [FBConfiguration setCustomActionsDelimiter:(NSString *)[settings objectForKey:FB_SETTING_CUSTOM_ACTIONS_DELIMITER]];
+  }
   if (nil != [settings objectForKey:FB_SETTING_ENFORCE_CUSTOM_SNAPSHOTS]) {
     [FBConfiguration setEnforceCustomSnapshots:[[settings objectForKey:FB_SETTING_ENFORCE_CUSTOM_SNAPSHOTS] boolValue]];
   }

WebDriverAgentLib/Utilities/FBConfiguration.h

@@ -387,6 +387,15 @@ typedef NS_ENUM(NSInteger, FBConfigurationKeyboardPreference) {
 + (void)setIncludeCustomActionsInPageSource:(BOOL)enabled;
 + (BOOL)includeCustomActionsInPageSource;
 
+/**
+ * Sets the delimiter string used when joining custom action names.
+ * Defaults to ", " (comma followed by space).
+ *
+ * @param delimiter The delimiter string to use when joining custom actions
+ */
++ (void)setCustomActionsDelimiter:(NSString *)delimiter;
++ (NSString *)customActionsDelimiter;
+
 /**
  * Whether to enforce the use of custom snapshots instead of standard snapshots.
  * When enabled, fb_customSnapshot is always invoked instead of fb_standardSnapshot

WebDriverAgentLib/Utilities/FBConfiguration.m

@@ -65,6 +65,7 @@
 static BOOL FBShouldIncludeMinMaxValueInPageSource = NO;
 static BOOL FBShouldIncludeCustomActionsInPageSource = NO;
 static BOOL FBShouldEnforceCustomSnapshots = NO;
+static NSString *FBCustomActionsDelimiter;
 
 @implementation FBConfiguration
 
@@ -543,6 +544,7 @@ + (void)resetSessionSettings
   FBSetCustomParameterForElementSnapshot(FBSnapshotMaxDepthKey, @50);
   FBUseClearTextShortcut = YES;
   FBLimitXpathContextScope = YES;
+  FBCustomActionsDelimiter = @", ";
 #if !TARGET_OS_TV
   FBScreenshotOrientation = UIInterfaceOrientationUnknown;
 #endif
@@ -698,6 +700,16 @@ + (BOOL)includeCustomActionsInPageSource
   return FBShouldIncludeCustomActionsInPageSource;
 }
 
++ (void)setCustomActionsDelimiter:(NSString *)delimiter
+{
+  FBCustomActionsDelimiter = delimiter ?: @", ";
+}
+
++ (NSString *)customActionsDelimiter
+{
+  return FBCustomActionsDelimiter ?: @", ";
+}
+
 + (void)setEnforceCustomSnapshots:(BOOL)enabled
 {
   FBShouldEnforceCustomSnapshots = enabled;

WebDriverAgentLib/Utilities/FBSettings.h

@@ -43,6 +43,7 @@ extern NSString *const FB_SETTING_INCLUDE_HITTABLE_IN_PAGE_SOURCE;
 extern NSString *const FB_SETTING_INCLUDE_NATIVE_FRAME_IN_PAGE_SOURCE;
 extern NSString *const FB_SETTING_INCLUDE_MIN_MAX_VALUE_IN_PAGE_SOURCE;
 extern NSString *const FB_SETTING_INCLUDE_CUSTOM_ACTIONS_IN_PAGE_SOURCE;
+extern NSString *const FB_SETTING_CUSTOM_ACTIONS_DELIMITER;
 extern NSString *const FB_SETTING_ENFORCE_CUSTOM_SNAPSHOTS;
 
 NS_ASSUME_NONNULL_END

WebDriverAgentLib/Utilities/FBSettings.m

@@ -39,4 +39,5 @@
 NSString* const FB_SETTING_INCLUDE_NATIVE_FRAME_IN_PAGE_SOURCE = @"includeNativeFrameInPageSource";
 NSString* const FB_SETTING_INCLUDE_MIN_MAX_VALUE_IN_PAGE_SOURCE = @"includeMinMaxValueInPageSource";
 NSString* const FB_SETTING_INCLUDE_CUSTOM_ACTIONS_IN_PAGE_SOURCE = @"includeCustomActionsInPageSource";
+NSString* const FB_SETTING_CUSTOM_ACTIONS_DELIMITER = @"customActionsDelimiter";
 NSString* const FB_SETTING_ENFORCE_CUSTOM_SNAPSHOTS = @"enforceCustomSnapshots";

WebDriverAgentTests/IntegrationApp/Classes/ViewController.m

@@ -10,10 +10,32 @@
 
 @interface ViewController ()
 @property (weak, nonatomic) IBOutlet UILabel *orentationLabel;
+@property (weak, nonatomic) IBOutlet UIButton *button;
 @end
 
 @implementation ViewController
 
+- (void)viewDidLoad
+{
+  [super viewDidLoad];
+  
+  UIAccessibilityCustomAction *action1 =
+  [[UIAccessibilityCustomAction alloc] initWithName:@"Custom Action 1"
+                                             target:self
+                                           selector:@selector(handleCustomAction:)];
+  UIAccessibilityCustomAction *action2 =
+  [[UIAccessibilityCustomAction alloc] initWithName:@"Custom Action 2"
+                                             target:self
+                                           selector:@selector(handleCustomAction:)];
+  self.button.accessibilityCustomActions = @[action1, action2];
+}
+
+- (BOOL)handleCustomAction:(UIAccessibilityCustomAction *)action
+{
+  // Custom action handler - just return YES to indicate success
+  return YES;
+}
+
 - (IBAction)deadlockApp:(id)sender
 {
   dispatch_sync(dispatch_get_main_queue(), ^{