fix: Address compilation warnings (#1143)

mykola-mokhnach · web-flow · commit f1f9976f4a0a · 2026-05-23T21:00:55.000+02:00
diff --git a/.gitignore b/.gitignore
@@ -9,6 +9,7 @@
 build/
 clang/
 DerivedData
+wdaBuild/
 
 ## Various settings
 *.pbxuser
diff --git a/WebDriverAgentLib/Categories/XCUIDevice+FBHelpers.m b/WebDriverAgentLib/Categories/XCUIDevice+FBHelpers.m
@@ -232,7 +232,7 @@ - (BOOL)fb_openUrl:(NSString *)url error:(NSError **)error
   NSString *description = [NSString stringWithFormat:@"Cannot open '%@' with the default application assigned for it. Consider upgrading to Xcode 14.3+/iOS 16.4+", url];
   return [[[FBErrorBuilder builder]
            withDescriptionFormat:@"%@", description]
-          buildError:error];;
+          buildError:error];
 }
 
 - (BOOL)fb_openUrl:(NSString *)url withApplication:(NSString *)bundleId error:(NSError **)error
diff --git a/WebDriverAgentLib/Categories/XCUIDevice+FBRotation.m b/WebDriverAgentLib/Categories/XCUIDevice+FBRotation.m
@@ -30,19 +30,38 @@ - (BOOL)fb_setDeviceRotation:(NSDictionary *)rotationObj
   if (keysForRotationObj.count == 0) {
     return NO;
   }
-  NSInteger orientation = keysForRotationObj.firstObject.integerValue;
+  UIDeviceOrientation orientation = (UIDeviceOrientation)keysForRotationObj.firstObject.integerValue;
   XCUIApplication *application = XCUIApplication.fb_activeApplication;
   [XCUIDevice sharedDevice].orientation = orientation;
   return [self waitUntilInterfaceIsAtOrientation:orientation application:application];
 }
 
-- (BOOL)waitUntilInterfaceIsAtOrientation:(NSInteger)orientation application:(XCUIApplication *)application
+static UIInterfaceOrientation FBInterfaceOrientationFromDeviceOrientation(UIDeviceOrientation orientation)
+{
+  switch (orientation) {
+    case UIDeviceOrientationPortrait:
+      return UIInterfaceOrientationPortrait;
+    case UIDeviceOrientationPortraitUpsideDown:
+      return UIInterfaceOrientationPortraitUpsideDown;
+    case UIDeviceOrientationLandscapeLeft:
+      return UIInterfaceOrientationLandscapeRight;
+    case UIDeviceOrientationLandscapeRight:
+      return UIInterfaceOrientationLandscapeLeft;
+    case UIDeviceOrientationUnknown:
+    case UIDeviceOrientationFaceUp:
+    case UIDeviceOrientationFaceDown:
+    default:
+      return UIInterfaceOrientationUnknown;
+  }
+}
+
+- (BOOL)waitUntilInterfaceIsAtOrientation:(UIDeviceOrientation)orientation application:(XCUIApplication *)application
 {
   // Tapping elements immediately after rotation may fail due to way UIKit is handling touches.
   // We should wait till UI cools off, before continuing
   [application fb_waitUntilStableWithTimeout:FBConfiguration.animationCoolOffTimeout];
 
-  return application.interfaceOrientation == orientation;
+  return application.interfaceOrientation == FBInterfaceOrientationFromDeviceOrientation(orientation);
 }
 
 - (NSDictionary *)fb_rotationMapping
diff --git a/WebDriverAgentLib/Categories/XCUIElement+FBUtilities.m b/WebDriverAgentLib/Categories/XCUIElement+FBUtilities.m
@@ -113,7 +113,7 @@ @implementation XCUIElement (FBUtilities)
   XCUIElementType type = XCUIElementTypeAny;
   NSArray<NSNumber *> *uniqueTypes = [snapshots valueForKeyPath:[NSString stringWithFormat:@"@distinctUnionOfObjects.%@", FBStringify(XCUIElement, elementType)]];
   if (uniqueTypes && [uniqueTypes count] == 1) {
-    type = [uniqueTypes.firstObject intValue];
+    type = (XCUIElementType)[uniqueTypes.firstObject intValue];
   }
   XCUIElementQuery *query = onlyChildren
     ? [self.fb_query childrenMatchingType:type]
diff --git a/WebDriverAgentLib/Categories/XCUIElement+FBVisibleFrame.m b/WebDriverAgentLib/Categories/XCUIElement+FBVisibleFrame.m
@@ -29,13 +29,19 @@ - (CGRect)fb_visibleFrame
 {
   CGRect thisVisibleFrame = [self visibleFrame];
   if (!CGRectIsEmpty(thisVisibleFrame)) {
-    return thisVisibleFrame;
+    return CGRectMake(CGRectGetMinX(thisVisibleFrame),
+                      CGRectGetMinY(thisVisibleFrame),
+                      CGRectGetWidth(thisVisibleFrame),
+                      CGRectGetHeight(thisVisibleFrame));
   }
 
   NSDictionary *visibleFrameDict = [self fb_attributeValue:FB_XCAXAVisibleFrameAttributeName
                                                      error:nil];
   if (nil == visibleFrameDict) {
-    return thisVisibleFrame;
+    return CGRectMake(CGRectGetMinX(thisVisibleFrame),
+                      CGRectGetMinY(thisVisibleFrame),
+                      CGRectGetWidth(thisVisibleFrame),
+                      CGRectGetHeight(thisVisibleFrame));
   }
 
   id x = [visibleFrameDict objectForKey:@"X"];
@@ -46,7 +52,10 @@ - (CGRect)fb_visibleFrame
     return CGRectMake([x doubleValue], [y doubleValue], [width doubleValue], [height doubleValue]);
   }
 
-  return thisVisibleFrame;
+  return CGRectMake(CGRectGetMinX(thisVisibleFrame),
+                    CGRectGetMinY(thisVisibleFrame),
+                    CGRectGetWidth(thisVisibleFrame),
+                    CGRectGetHeight(thisVisibleFrame));
 }
 
 @end
diff --git a/WebDriverAgentLib/Commands/FBCustomCommands.m b/WebDriverAgentLib/Commands/FBCustomCommands.m
@@ -253,7 +253,7 @@ + (NSDictionary *)processArguments:(XCUIApplication *)app
   if (nil == result) {
     return FBResponseWithUnknownError(error);
   }
-  return FBResponseWithObject([result base64EncodedStringWithOptions:0]);
+  return FBResponseWithObject([result base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0]);
 }
 
 + (id<FBResponsePayload>)handleGetBatteryInfo:(FBRouteRequest *)request
@@ -599,7 +599,7 @@ + (NSString *)timeZone
         modifierFlags = [(NSNumber *)modifiers unsignedIntValue];
       }
       NSString *keyValue = [FBKeyboard keyValueForName:item] ?: key;
-      [destination typeKey:keyValue modifierFlags:modifierFlags];
+      [destination typeKey:keyValue modifierFlags:(XCUIKeyModifierFlags)modifierFlags];
     } else {
       NSString *message = @"All items of the 'keys' array must be either dictionaries or strings";
       return FBResponseWithStatus([FBCommandStatus invalidArgumentErrorWithMessage:message
diff --git a/WebDriverAgentLib/Commands/FBElementCommands.m b/WebDriverAgentLib/Commands/FBElementCommands.m
@@ -574,7 +574,7 @@ + (NSArray *)routes
                                                                                 traceback:nil]);
       }
     }
-    NSString *screenshot = [screenshotData base64EncodedStringWithOptions:0];
+    NSString *screenshot = [screenshotData base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0];
     screenshotData = nil;
     return FBResponseWithObject(screenshot);
   }
diff --git a/WebDriverAgentLib/Commands/FBOrientationCommands.m b/WebDriverAgentLib/Commands/FBOrientationCommands.m
@@ -139,7 +139,7 @@ + (BOOL)setDeviceOrientation:(NSString *)orientation forApplication:(XCUIApplica
   if (orientationValue == nil) {
     return NO;
   }
-  return [[XCUIDevice sharedDevice] fb_setDeviceInterfaceOrientation:orientationValue.integerValue];
+  return [[XCUIDevice sharedDevice] fb_setDeviceInterfaceOrientation:(UIDeviceOrientation)orientationValue.integerValue];
 }
 
 + (NSDictionary *)_orientationsMapping
diff --git a/WebDriverAgentLib/Commands/FBScreenshotCommands.m b/WebDriverAgentLib/Commands/FBScreenshotCommands.m
@@ -33,7 +33,7 @@ + (NSArray *)routes
   if (nil == screenshotData) {
     return FBResponseWithStatus([FBCommandStatus unableToCaptureScreenErrorWithMessage:error.description traceback:nil]);
   }
-  NSString *screenshot = [screenshotData base64EncodedStringWithOptions:0];
+  NSString *screenshot = [screenshotData base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0];
   return FBResponseWithObject(screenshot);
 }
 
diff --git a/WebDriverAgentLib/Routing/FBScreenRecordingRequest.m b/WebDriverAgentLib/Routing/FBScreenRecordingRequest.m
@@ -46,7 +46,7 @@ - (nullable id)createVideoEncodingWithError:(NSError **)error
   [videoEncodingInitInvocation setSelector:videoEncodingConstructorSelector];
   long long codec = self.codec;
   [videoEncodingInitInvocation setArgument:&codec atIndex:2];
-  double frameRate = self.fps;
+  double frameRate = (double)self.fps;
   [videoEncodingInitInvocation setArgument:&frameRate atIndex:3];
   [videoEncodingInitInvocation invokeWithTarget:videoEncodingAllocated];
   id __unsafe_unretained result;
diff --git a/WebDriverAgentLib/Routing/FBTCPSocket.m b/WebDriverAgentLib/Routing/FBTCPSocket.m
@@ -39,7 +39,7 @@ - (instancetype)initWithPort:(uint16_t)port
 - (BOOL)startWithError:(NSError **)error
 {
   if (![self.listeningSocket acceptOnPort:self.port error:error]) {
-    return NO;;
+    return NO;
   }
 
   return YES;
diff --git a/WebDriverAgentLib/Utilities/FBClassChainQueryParser.m b/WebDriverAgentLib/Utilities/FBClassChainQueryParser.m
@@ -117,7 +117,7 @@ - (void)appendChar:(unichar)character
 {
   NSMutableString *value = [NSMutableString stringWithString:self.asString];
   [value appendFormat:@"%C", character];
-  self.asString = value.copy;;
+  self.asString = value.copy;
 }
 
 - (nullable FBBaseClassChainToken*)followingTokenBasedOn:(unichar)character
diff --git a/WebDriverAgentLib/Utilities/FBImageProcessor.m b/WebDriverAgentLib/Utilities/FBImageProcessor.m
@@ -25,6 +25,7 @@
 @interface FBImageProcessor ()
 
 @property (nonatomic) NSData *nextImage;
+@property (nonatomic) NSMutableArray<void (^)(NSData *)> *pendingCompletionHandlers;
 @property (nonatomic, readonly) NSLock *nextImageLock;
 @property (nonatomic, readonly) dispatch_queue_t scalingQueue;
 @property (atomic, assign) BOOL isScalingScheduled;
@@ -38,6 +39,7 @@ - (id)init
   self = [super init];
   if (self) {
     _nextImageLock = [[NSLock alloc] init];
+    _pendingCompletionHandlers = [NSMutableArray array];
     _scalingQueue = dispatch_queue_create("image.scaling.queue", NULL);
     _isScalingScheduled = NO;
   }
@@ -53,6 +55,7 @@ - (void)submitImageData:(NSData *)image
     [FBLogger verboseLog:@"Discarding screenshot"];
   }
   self.nextImage = image;
+  [self.pendingCompletionHandlers addObject:[completionHandler copy]];
   BOOL shouldSchedule = !self.isScalingScheduled;
   if (shouldSchedule) {
     self.isScalingScheduled = YES;
@@ -62,14 +65,14 @@ - (void)submitImageData:(NSData *)image
     return;
   }
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wcompletion-handler"
   dispatch_async(self.scalingQueue, ^{
     while (YES) {
       @autoreleasepool {
         [self.nextImageLock lock];
         NSData *nextImageData = self.nextImage;
         self.nextImage = nil;
+        NSArray<void (^)(NSData *)> *handlers = [self.pendingCompletionHandlers copy];
+        [self.pendingCompletionHandlers removeAllObjects];
         if (nextImageData == nil) {
           self.isScalingScheduled = NO;
           [self.nextImageLock unlock];
@@ -80,7 +83,7 @@ - (void)submitImageData:(NSData *)image
         // We do not want this value to be too high because then we get images larger in size than original ones
         // Although, we also don't want to lose too much of the quality on recompression
         CGFloat recompressionQuality = MAX(0.9,
-                                           MIN(FBMaxCompressionQuality, FBConfiguration.mjpegServerScreenshotQuality / 100.0));
+                                           MIN(FBMaxCompressionQuality, (double)FBConfiguration.mjpegServerScreenshotQuality / 100.0));
         NSData *thumbnailData = [self.class fixedImageDataWithImageData:nextImageData
                                                           scalingFactor:scalingFactor
                                                                     uti:UTTypeJPEG
@@ -89,11 +92,13 @@ - (void)submitImageData:(NSData *)image
         // Use it with care. See https://github.com/appium/WebDriverAgent/pull/812
                                                          fixOrientation:FBConfiguration.mjpegShouldFixOrientation
                                                      desiredOrientation:nil];
-        completionHandler(thumbnailData ?: nextImageData);
+        NSData *processedImageData = thumbnailData ?: nextImageData;
+        for (void (^handler)(NSData *) in handlers) {
+          handler(processedImageData);
+        }
       }
     }
   });
-#pragma clang diagnostic pop
 }
 
 + (nullable NSData *)fixedImageDataWithImageData:(NSData *)imageData
diff --git a/WebDriverAgentLib/Utilities/FBMjpegServer.m b/WebDriverAgentLib/Utilities/FBMjpegServer.m
@@ -95,7 +95,7 @@ - (void)streamScreenshot
     return;
   }
   NSUInteger framerate = FBNormalizedMjpegFramerate(FBConfiguration.mjpegServerFramerate);
-  uint64_t timerInterval = (uint64_t)(1.0 / framerate * NSEC_PER_SEC);
+  uint64_t timerInterval = (uint64_t)(1.0 / (double)framerate * NSEC_PER_SEC);
   uint64_t timeStarted = clock_gettime_nsec_np(CLOCK_MONOTONIC_RAW);
   @synchronized (self.listeningClients) {
     if (0 == self.listeningClients.count) {
@@ -106,7 +106,7 @@ - (void)streamScreenshot
 
   NSError *error;
   CGFloat compressionQuality = MAX(FBMinCompressionQuality,
-                                   MIN(FBMaxCompressionQuality, FBConfiguration.mjpegServerScreenshotQuality / 100.0));
+                                   MIN(FBMaxCompressionQuality, (double)FBConfiguration.mjpegServerScreenshotQuality / 100.0));
   NSData *screenshotData = [FBScreenshot takeInOriginalResolutionWithScreenID:self.mainScreenID
                                                            compressionQuality:compressionQuality
                                                                           uti:UTTypeJPEG
diff --git a/WebDriverAgentLib/Utilities/FBScreenshot.m b/WebDriverAgentLib/Utilities/FBScreenshot.m
@@ -126,7 +126,7 @@ + (NSData *)takeInOriginalResolutionWithScreenID:(long long)screenID
         withDescription:timeoutMsg]
        buildError:error];
     }
-  };
+  }
   if (nil != error && nil != innerError) {
     *error = innerError;
   }
diff --git a/WebDriverAgentLib/Utilities/XCTestPrivateSymbols.h b/WebDriverAgentLib/Utilities/XCTestPrivateSymbols.h
@@ -50,8 +50,8 @@ extern NSArray<NSNumber *> *(*XCAXAccessibilityAttributesForStringAttributes)(id
  */
 void *FBRetrieveXCTestSymbol(const char *name);
 
-/*! Static constructor that will retrieve XCTest private symbols */
-__attribute__((constructor)) void FBLoadXCTestSymbols(void);
+/*! Loads XCTest private symbols. Safe to call multiple times. */
+void FBLoadXCTestSymbols(void);
 
 /**
  Method is used to tranform attribute names into the format, which
diff --git a/WebDriverAgentLib/Utilities/XCTestPrivateSymbols.m b/WebDriverAgentLib/Utilities/XCTestPrivateSymbols.m
@@ -30,41 +30,56 @@
 
 NSArray<NSNumber *> *(*XCAXAccessibilityAttributesForStringAttributes)(id);
 
-__attribute__((constructor)) void FBLoadXCTestSymbols(void)
+@interface FBXCTestSymbolsLoader : NSObject
+@end
+
+@implementation FBXCTestSymbolsLoader
+
++ (void)load
+{
+  FBLoadXCTestSymbols();
+}
+
+@end
+
+void FBLoadXCTestSymbols(void)
 {
-  NSString *XC_kAXXCAttributeIsVisible = *(NSString*__autoreleasing*)FBRetrieveXCTestSymbol([FB_XCAXAIsVisibleAttributeName UTF8String]);
-  NSString *XC_kAXXCAttributeIsElement = *(NSString*__autoreleasing*)FBRetrieveXCTestSymbol([FB_XCAXAIsElementAttributeName UTF8String]);
-
-  XCAXAccessibilityAttributesForStringAttributes =
-  (NSArray<NSNumber *> *(*)(id))FBRetrieveXCTestSymbol("XCAXAccessibilityAttributesForStringAttributes");
-
-  XCSetDebugLogger = (void (*)(id <XCDebugLogDelegate>))FBRetrieveXCTestSymbol("XCSetDebugLogger");
-  XCDebugLogger = (id<XCDebugLogDelegate>(*)(void))FBRetrieveXCTestSymbol("XCDebugLogger");
-
-  NSArray<NSNumber *> *accessibilityAttributes = XCAXAccessibilityAttributesForStringAttributes(@[XC_kAXXCAttributeIsVisible, XC_kAXXCAttributeIsElement]);
-  FB_XCAXAIsVisibleAttribute = accessibilityAttributes[0];
-  FB_XCAXAIsElementAttribute = accessibilityAttributes[1];
-
-  NSCAssert(FB_XCAXAIsVisibleAttribute != nil , @"Failed to retrieve FB_XCAXAIsVisibleAttribute", FB_XCAXAIsVisibleAttribute);
-  NSCAssert(FB_XCAXAIsElementAttribute != nil , @"Failed to retrieve FB_XCAXAIsElementAttribute", FB_XCAXAIsElementAttribute);
-  
-  NSString *XC_kAXXCAttributeMinValue = *(NSString *__autoreleasing *)FBRetrieveXCTestSymbol([FB_XCAXACustomMinValueAttributeName UTF8String]);
-  NSString *XC_kAXXCAttributeMaxValue = *(NSString *__autoreleasing *)FBRetrieveXCTestSymbol([FB_XCAXACustomMaxValueAttributeName UTF8String]);
-  
-  NSString *XC_kAXXCAttributeCustomActions = *(NSString *__autoreleasing *)FBRetrieveXCTestSymbol([FB_XCAXACustomActionsAttributeName UTF8String]);
-  
-  NSArray<NSNumber *> *customAttrs = XCAXAccessibilityAttributesForStringAttributes(@[
-    XC_kAXXCAttributeMinValue,
-    XC_kAXXCAttributeMaxValue,
-    XC_kAXXCAttributeCustomActions
-  ]);
-  FB_XCAXACustomMinValueAttribute = customAttrs[0];
-  FB_XCAXACustomMaxValueAttribute = customAttrs[1];
-  FB_XCAXACustomActionsAttribute = customAttrs[2];
-  
-  NSCAssert(FB_XCAXACustomMinValueAttribute != nil, @"Failed to retrieve FB_XCAXACustomMinValueAttribute", FB_XCAXACustomMinValueAttribute);
-  NSCAssert(FB_XCAXACustomMaxValueAttribute != nil, @"Failed to retrieve FB_XCAXACustomMaxValueAttribute", FB_XCAXACustomMaxValueAttribute);
-  NSCAssert(FB_XCAXACustomActionsAttribute != nil, @"Failed to retrieve FB_XCAXACustomActionsAttribute", FB_XCAXACustomActionsAttribute);
+  static dispatch_once_t loadOnceToken;
+  dispatch_once(&loadOnceToken, ^{
+    NSString *XC_kAXXCAttributeIsVisible = *(NSString*__autoreleasing*)FBRetrieveXCTestSymbol([FB_XCAXAIsVisibleAttributeName UTF8String]);
+    NSString *XC_kAXXCAttributeIsElement = *(NSString*__autoreleasing*)FBRetrieveXCTestSymbol([FB_XCAXAIsElementAttributeName UTF8String]);
+
+    XCAXAccessibilityAttributesForStringAttributes =
+    (NSArray<NSNumber *> *(*)(id))FBRetrieveXCTestSymbol("XCAXAccessibilityAttributesForStringAttributes");
+
+    XCSetDebugLogger = (void (*)(id <XCDebugLogDelegate>))FBRetrieveXCTestSymbol("XCSetDebugLogger");
+    XCDebugLogger = (id<XCDebugLogDelegate>(*)(void))FBRetrieveXCTestSymbol("XCDebugLogger");
+
+    NSArray<NSNumber *> *accessibilityAttributes = XCAXAccessibilityAttributesForStringAttributes(@[XC_kAXXCAttributeIsVisible, XC_kAXXCAttributeIsElement]);
+    FB_XCAXAIsVisibleAttribute = accessibilityAttributes[0];
+    FB_XCAXAIsElementAttribute = accessibilityAttributes[1];
+
+    NSCAssert(FB_XCAXAIsVisibleAttribute != nil , @"Failed to retrieve FB_XCAXAIsVisibleAttribute", FB_XCAXAIsVisibleAttribute);
+    NSCAssert(FB_XCAXAIsElementAttribute != nil , @"Failed to retrieve FB_XCAXAIsElementAttribute", FB_XCAXAIsElementAttribute);
+
+    NSString *XC_kAXXCAttributeMinValue = *(NSString *__autoreleasing *)FBRetrieveXCTestSymbol([FB_XCAXACustomMinValueAttributeName UTF8String]);
+    NSString *XC_kAXXCAttributeMaxValue = *(NSString *__autoreleasing *)FBRetrieveXCTestSymbol([FB_XCAXACustomMaxValueAttributeName UTF8String]);
+
+    NSString *XC_kAXXCAttributeCustomActions = *(NSString *__autoreleasing *)FBRetrieveXCTestSymbol([FB_XCAXACustomActionsAttributeName UTF8String]);
+
+    NSArray<NSNumber *> *customAttrs = XCAXAccessibilityAttributesForStringAttributes(@[
+      XC_kAXXCAttributeMinValue,
+      XC_kAXXCAttributeMaxValue,
+      XC_kAXXCAttributeCustomActions
+    ]);
+    FB_XCAXACustomMinValueAttribute = customAttrs[0];
+    FB_XCAXACustomMaxValueAttribute = customAttrs[1];
+    FB_XCAXACustomActionsAttribute = customAttrs[2];
+
+    NSCAssert(FB_XCAXACustomMinValueAttribute != nil, @"Failed to retrieve FB_XCAXACustomMinValueAttribute", FB_XCAXACustomMinValueAttribute);
+    NSCAssert(FB_XCAXACustomMaxValueAttribute != nil, @"Failed to retrieve FB_XCAXACustomMaxValueAttribute", FB_XCAXACustomMaxValueAttribute);
+    NSCAssert(FB_XCAXACustomActionsAttribute != nil, @"Failed to retrieve FB_XCAXACustomActionsAttribute", FB_XCAXACustomActionsAttribute);
+  });
 }
 
 void *FBRetrieveXCTestSymbol(const char *name)
diff --git a/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncSocket.m b/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncSocket.m
diff --git a/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncUdpSocket.m b/WebDriverAgentLib/Vendor/CocoaAsyncSocket/GCDAsyncUdpSocket.m
diff --git a/WebDriverAgentLib/Vendor/CocoaHTTPServer/Categories/DDRange.m b/WebDriverAgentLib/Vendor/CocoaHTTPServer/Categories/DDRange.m
diff --git a/WebDriverAgentLib/Vendor/CocoaHTTPServer/HTTPLogging.h b/WebDriverAgentLib/Vendor/CocoaHTTPServer/HTTPLogging.h
diff --git a/WebDriverAgentLib/Vendor/CocoaHTTPServer/HTTPMessage.m b/WebDriverAgentLib/Vendor/CocoaHTTPServer/HTTPMessage.m
diff --git a/WebDriverAgentLib/Vendor/RoutingHTTPServer/RoutingHTTPServer.m b/WebDriverAgentLib/Vendor/RoutingHTTPServer/RoutingHTTPServer.m

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ - (BOOL)fb_openUrl:(NSString )url error:(NSError *)error`
`232`	`232`	`NSString *description = [NSString stringWithFormat:@"Cannot open '%@' with the default application assigned for it. Consider upgrading to Xcode 14.3+/iOS 16.4+", url];`
`233`	`233`	`return [[[FBErrorBuilder builder]`
`234`	`234`	`withDescriptionFormat:@"%@", description]`
`235`		`- buildError:error];;`
	`235`	`+ buildError:error];`
`236`	`236`	`}`
`237`	`237`
`238`	`238`	`- (BOOL)fb_openUrl:(NSString )url withApplication:(NSString )bundleId error:(NSError **)error`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ @implementation XCUIElement (FBUtilities)`
`113`	`113`	`XCUIElementType type = XCUIElementTypeAny;`
`114`	`114`	`NSArray<NSNumber > uniqueTypes = [snapshots valueForKeyPath:[NSString stringWithFormat:@"@distinctUnionOfObjects.%@", FBStringify(XCUIElement, elementType)]];`
`115`	`115`	`if (uniqueTypes && [uniqueTypes count] == 1) {`
`116`		`- type = [uniqueTypes.firstObject intValue];`
	`116`	`+ type = (XCUIElementType)[uniqueTypes.firstObject intValue];`
`117`	`117`	`}`
`118`	`118`	`XCUIElementQuery *query = onlyChildren`
`119`	`119`	`? [self.fb_query childrenMatchingType:type]`
Original file line number	Diff line number	Diff line change
`@@ -29,13 +29,19 @@ - (CGRect)fb_visibleFrame`
`29`	`29`	`{`
`30`	`30`	`CGRect thisVisibleFrame = [self visibleFrame];`
`31`	`31`	`if (!CGRectIsEmpty(thisVisibleFrame)) {`
`32`		`- return thisVisibleFrame;`
	`32`	`+ return CGRectMake(CGRectGetMinX(thisVisibleFrame),`
	`33`	`+ CGRectGetMinY(thisVisibleFrame),`
	`34`	`+ CGRectGetWidth(thisVisibleFrame),`
	`35`	`+ CGRectGetHeight(thisVisibleFrame));`
`33`	`36`	`}`
`34`	`37`
`35`	`38`	`NSDictionary *visibleFrameDict = [self fb_attributeValue:FB_XCAXAVisibleFrameAttributeName`
`36`	`39`	`error:nil];`
`37`	`40`	`if (nil == visibleFrameDict) {`
`38`		`- return thisVisibleFrame;`
	`41`	`+ return CGRectMake(CGRectGetMinX(thisVisibleFrame),`
	`42`	`+ CGRectGetMinY(thisVisibleFrame),`
	`43`	`+ CGRectGetWidth(thisVisibleFrame),`
	`44`	`+ CGRectGetHeight(thisVisibleFrame));`
`39`	`45`	`}`
`40`	`46`
`41`	`47`	`id x = [visibleFrameDict objectForKey:@"X"];`
`@@ -46,7 +52,10 @@ - (CGRect)fb_visibleFrame`
`46`	`52`	`return CGRectMake([x doubleValue], [y doubleValue], [width doubleValue], [height doubleValue]);`
`47`	`53`	`}`
`48`	`54`
`49`		`- return thisVisibleFrame;`
	`55`	`+ return CGRectMake(CGRectGetMinX(thisVisibleFrame),`
	`56`	`+ CGRectGetMinY(thisVisibleFrame),`
	`57`	`+ CGRectGetWidth(thisVisibleFrame),`
	`58`	`+ CGRectGetHeight(thisVisibleFrame));`
`50`	`59`	`}`
`51`	`60`
`52`	`61`	`@end`
Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,7 @@ + (NSDictionary )processArguments:(XCUIApplication )app`
`253`	`253`	`if (nil == result) {`
`254`	`254`	`return FBResponseWithUnknownError(error);`
`255`	`255`	`}`
`256`		`- return FBResponseWithObject([result base64EncodedStringWithOptions:0]);`
	`256`	`+ return FBResponseWithObject([result base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0]);`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`+ (id<FBResponsePayload>)handleGetBatteryInfo:(FBRouteRequest *)request`
`@@ -599,7 +599,7 @@ + (NSString *)timeZone`
`599`	`599`	`modifierFlags = [(NSNumber *)modifiers unsignedIntValue];`
`600`	`600`	`}`
`601`	`601`	`NSString *keyValue = [FBKeyboard keyValueForName:item] ?: key;`
`602`		`- [destination typeKey:keyValue modifierFlags:modifierFlags];`
	`602`	`+ [destination typeKey:keyValue modifierFlags:(XCUIKeyModifierFlags)modifierFlags];`
`603`	`603`	`} else {`
`604`	`604`	`NSString *message = @"All items of the 'keys' array must be either dictionaries or strings";`
`605`	`605`	`return FBResponseWithStatus([FBCommandStatus invalidArgumentErrorWithMessage:message`
Original file line number	Diff line number	Diff line change
`@@ -574,7 +574,7 @@ + (NSArray *)routes`
`574`	`574`	`traceback:nil]);`
`575`	`575`	`}`
`576`	`576`	`}`
`577`		`- NSString *screenshot = [screenshotData base64EncodedStringWithOptions:0];`
	`577`	`+ NSString *screenshot = [screenshotData base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0];`
`578`	`578`	`screenshotData = nil;`
`579`	`579`	`return FBResponseWithObject(screenshot);`
`580`	`580`	`}`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ + (BOOL)setDeviceOrientation:(NSString *)orientation forApplication:(XCUIApplica`
`139`	`139`	`if (orientationValue == nil) {`
`140`	`140`	`return NO;`
`141`	`141`	`}`
`142`		`- return [[XCUIDevice sharedDevice] fb_setDeviceInterfaceOrientation:orientationValue.integerValue];`
	`142`	`+ return [[XCUIDevice sharedDevice] fb_setDeviceInterfaceOrientation:(UIDeviceOrientation)orientationValue.integerValue];`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`+ (NSDictionary *)_orientationsMapping`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ + (NSArray *)routes`
`33`	`33`	`if (nil == screenshotData) {`
`34`	`34`	`return FBResponseWithStatus([FBCommandStatus unableToCaptureScreenErrorWithMessage:error.description traceback:nil]);`
`35`	`35`	`}`
`36`		`- NSString *screenshot = [screenshotData base64EncodedStringWithOptions:0];`
	`36`	`+ NSString *screenshot = [screenshotData base64EncodedStringWithOptions:(NSDataBase64EncodingOptions)0];`
`37`	`37`	`return FBResponseWithObject(screenshot);`
`38`	`38`	`}`
`39`	`39`