fix: Missing text in long text for get text/value

[KazuCocoa]

This PR changes the "Text Field long text" to much longer one to demonstrate eca2ed1 (Before #970 regression.

Before the change:

while after the change failed:

Vanilla XCTest had the entire text appium/appium-xcuitest-driver#2552 (comment) .

[mykola-mokhnach]

Is it expected that the test should fail?

[mykola-mokhnach]

this fix helps to workaround the text length issue:

[KazuCocoa]

Thanks. do you think we could do the same thing in the page source as well...? If not, I think adding documentation would be sufficient

<XCUIElementTypeTextView type="XCUIElementTypeTextView" value="12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012" enabled="true" visible="true" accessible="true" x="20" y="508" width="390" height="354" index="13">
<XCUIElementTypeOther type="XCUIElementTypeOther" value="0%" name="Vertical scroll bar, 1 page" label="Vertical scroll bar, 1 page" enabled="true" visible="true" accessible="false" x="377" y="508" width="30" height="354" index="0">
	<XCUIElementTypeOther type="XCUIElementTypeOther" enabled="true" visible="false" accessible="false" x="404" y="588" width="3" height="245" index="0"/>

	
=> #<Appium::Core::Element:0x..fba76fa2a4534a244 id="1A000000-0000-0000-B0A3-000000000000">
[202] pry(main)> e.text                                                                                                                                           
=> "12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012"
[203] pry(main)> e.value                                                                                                                                          
=> "1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901"

I have added for the getText endpoint to call fb_takeSnapshot:YES, then it returned:

[215] pry(main)> e.text                                                                                                                                           
=> "1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901"

as well.

[mykola-mokhnach]

Thanks. do you think we could do the same thing in the page source as well...? If not, I think adding documentation would be sufficient

I assume Apple designed it this way due to two reasons:

• better preformance
• optimized memory usage

that it why I would keep built-in snapshots for the page source retrieval.

Maybe we could put the possibility to always deep snapshot for the page source retrieval under a setting though, but I really don't see a point of having huge attribute values in xmls

[github-actions]

🎉 This PR is included in version 9.5.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀