fix: Address possible NULL binding compiler warning#1091
Merged
Conversation
mykola-mokhnach
commented
Dec 18, 2025
mykola-mokhnach
commented
DanMPerfecto
approved these changes
Dec 18, 2025
DanMPerfecto
left a comment
DanMPerfecto
left a comment
There was a problem hiding this comment.
I'm unable to test it at the moment, but the logic looks good to me.
Dan-Maor
approved these changes
Dec 18, 2025
KazuCocoa
approved these changes
Dec 18, 2025
Comment on lines
+3174
to
+3176
| self->flags |= kConnecting; | ||
|
|
||
| [self->sendQueue addObject:packet]; | ||
| [self->sendQueue addObject:packet]; |
Member
There was a problem hiding this comment.
Maybe... these might need more spaces....? I guess this file has mixed with tabs/spaces...?
Author
There was a problem hiding this comment.
I think it makes sense to completely reformat the whole file in Xcode, but not in the same PR
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
## [10.5.2](v10.5.1...v10.5.2) (2025-12-18) ### Bug Fixes * Address possible NULL binding compiler warning ([#1091](#1091)) ([263e646](263e646))
|
🎉 This PR is included in version 10.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.