fix: Add explicit dependency on JSR 305 annotations library#2280
Merged
valfirst merged 1 commit intoappium:masterfrom Mar 27, 2025
Merged
Conversation
mykola-mokhnach
approved these changes
Mar 26, 2025
Contributor
|
Just for information, the recommended fix would be replacing annotations like See for example: https://github.com/selenide/selenide/pull/2889/files |
Collaborator
Author
|
@asolntsev thank you for the hint, let's eat the elephant one bite at a time: I'll merge this PR, because builds are failed, the next PR will replace JSR 305 annotations with JSpecify annotations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Fix the build: fix: add explicit dependency on JSR 305 annotations library.
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
The annotations
javax.annotation.Nonnullandjavax.annotation.Nullableused in the codebase came from librarycom.google.code.findbugs:jsr305. This library was a dependency ofcom.google.guava:guava, which in its turn is a depedendency of Selenium. Butjsr305dependency was removed in Guava33.4.3(google/guava#2960), and Guava was bumped from33.4.0to33.4.5in Selenium (SeleniumHQ/selenium@ced5b22). As the resultcom.google.code.findbugs:jsr305is not present in classpath anymore and lead to build failures: https://github.com/appium/java-client/actions/runs/14034948997/job/39290753396?pr=2279Short-term solution is to add JSR 305 dependency explicitly.
Long-term solution can be migration to JSpecify.