feat: drop deprecated start_logs_broadcast/stop_logs_broadcast methods (#1105)

* feat: drop boardcast for logs

* remove unnecessary deps

* use newer env for test

* update tests

* use lower version of timeout

Author: KazuCocoa

.github/workflows/functional-test.yml

@@ -14,11 +14,12 @@ concurrency:
 
 jobs:
   ios_test:
-    runs-on: macos-14
+    runs-on: macos-15
+    timeout-minutes: 90
     env:
-          XCODE_VERSION: 15.3
-          IOS_VERSION: 17.4
-          IOS_DEVICE_NAME: iPhone 15 Plus
+          XCODE_VERSION: 16.4
+          IOS_VERSION: 18.5
+          IOS_DEVICE_NAME: iPhone 16 Plus
 
     steps:
     - uses: actions/checkout@v6
@@ -65,6 +66,7 @@ jobs:
         bundle install
         rake ios
       name: Run tests
+      timeout-minutes: 60
       working-directory: ios_tests
 
     - name: Save server output

Gemfile

@@ -16,7 +16,6 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'appium_thor', '~> 2.0'
-gem 'fakefs', '~> 3.0.0'
 gem 'hashdiff', '~> 1.2.0'
 gem 'minitest', '~> 5.0'
 gem 'minitest-reporters', '~> 1.1'

android_tests/lib/android/specs/common/command/command.rb

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require 'tmpdir'
+
 # rake "android[driver]"
 class AndroidTest
   class Driver < Minitest::Test
@@ -105,20 +107,11 @@ def test_07_absolute_app_path
       validate_path 'sauce-storage:some_storage_suffix'
       validate_path 'http://www.saucelabs.com'
 
-      # fake real paths for osx/windows.
-      FakeFS.activate!
-
-      osx_existing_path = '/Users/user/myapp.app'
-      FileUtils.mkdir_p osx_existing_path
-      validate_path osx_existing_path
-
-      # TODO: FakeFS fails on Windows paths due to the drive letters.
-      # Look into how opscode/chef tests this.
-      # windows_existing_path = "C:\\Program Files\\myapp.apk"
-      # FileUtils.mkdir_p windows_existing_path
-      # validate_path windows_existing_path
-
-      FakeFS.deactivate!
+      Dir.mktmpdir do |tmp_dir|
+        existing_path = File.join(tmp_dir, 'myapp.app')
+        FileUtils.mkdir_p existing_path
+        validate_path existing_path
+      end
 
       # bundle id test
       validate_path 'my.bundle.id'

android_tests/lib/android/specs/driver.rb

@@ -16,7 +16,6 @@
 require 'minitest/autorun'
 require 'minitest/reporters'
 require 'minitest'
-require 'fakefs/safe'
 require 'hashdiff'
 require_relative '../../lib/appium_lib'
 
@@ -40,7 +39,12 @@ def start_driver(caps)
   driver = Appium::Driver.new(caps, true)
   # Tests expect methods defined on the minispec object
   Appium.promote_appium_methods Minitest::Test, driver
-  driver.start_driver
+
+  # Use bounded HTTP timeouts in tests to avoid CI hangs on stuck requests.
+  open_timeout = Integer(ENV.fetch('APPIUM_TEST_OPEN_TIMEOUT', '120'))
+  read_timeout = Integer(ENV.fetch('APPIUM_TEST_READ_TIMEOUT', '300'))
+
+  driver.start_driver(open_timeout: open_timeout, read_timeout: read_timeout)
 end
 
 dir = File.expand_path(File.join(Dir.pwd, 'lib'))

android_tests/lib/run.rb

@@ -13,8 +13,7 @@ Gem::Specification.new do |s|
   s.homepage      = 'https://github.com/appium/ruby_lib' # published as appium_lib
   s.require_paths = ['lib']
 
-  # TODO: We must remove start_logs_broadcast/stop_logs_broadcast to bump the appium_lib_core version to v12+.
-  s.add_dependency 'appium_lib_core', '>= 9.2.1', '< 12.0'
+  s.add_dependency 'appium_lib_core', '>= 9.2.1', '< 13.0'
   s.add_dependency 'nokogiri', '~> 1.8', '>= 1.8.1'
   s.add_dependency 'tomlrb', '>= 1.1', '< 3.0'
 

appium_lib.gemspec

@@ -1,7 +1,7 @@
 [caps]
 platformName = "ios"
-platformVersion = "17.4"
-deviceName ="iPhone 15 Plus"
+platformVersion = "18.5"
+deviceName ="iPhone 16 Plus"
 automationName = 'XCUITest'
 app = "../test_apps/UICatalog.app.zip"
 someCapability = "some_capability"

ios_tests/appium.txt

@@ -202,7 +202,7 @@ def test_17_find_ele_by_predicate_include
       end
 
       def test_18_find_eles_by_predicate_include
-        assert_equal find_eles_by_predicate_include(value: 'e').length, 49
+        assert_equal find_eles_by_predicate_include(value: 'e').length, 51
       end
 
       def test_19_first_ele

ios_tests/lib/ios/specs/common/command/command.rb

@@ -30,37 +30,6 @@ def shell(command, arguments)
         # --relaxed-security
         @driver.execute_script 'mobile: shell', args
       end
-
-      # @deprecated Please use BiDi implementation via `$driver.driver.bidi` directly instead.
-      #
-      # Starts Android logcat broadcast websocket
-      #
-      # @param [String] logcat_file A file path to write messages from a logcat WebSocket client
-      #
-      # @example
-      #
-      #   start_logs_broadcast 'outputfile.log' #=> #<Appium::Android::Command::WsLogcat:...>
-      #
-      def start_logs_broadcast(logcat_file = 'logcat.log')
-        @driver.execute_script 'mobile: startLogsBroadcast'
-
-        socket_url = "ws://#{URI.parse(server_url).host}:#{@core.port}/ws/session/#{@driver.session_id}/appium/device/logcat"
-        @logcat_client = ::Appium::Common::Command::WsLogcat.new(url: socket_url, output_file: logcat_file)
-      end
-
-      # @deprecated Please use BiDi implementation directly instead.
-      #
-      # Stop Android logcat broadcast websocket
-      #
-      # @example
-      #
-      #   stop_logs_broadcast #=> nil
-      #
-      def stop_logs_broadcast
-        @logcat_client.close
-
-        @driver.execute_script 'mobile: stopLogsBroadcast'
-      end
     end
   end
 end