feat: drop boardcast for logs

Author: KazuCocoa

android_tests/lib/android/specs/common/command/command.rb

@@ -13,8 +13,7 @@ Gem::Specification.new do |s|
   s.homepage      = 'https://github.com/appium/ruby_lib' # published as appium_lib
   s.require_paths = ['lib']
 
-  # TODO: We must remove start_logs_broadcast/stop_logs_broadcast to bump the appium_lib_core version to v12+.
-  s.add_dependency 'appium_lib_core', '>= 9.2.1', '< 12.0'
+  s.add_dependency 'appium_lib_core', '>= 9.2.1', '< 13.0'
   s.add_dependency 'nokogiri', '~> 1.8', '>= 1.8.1'
   s.add_dependency 'tomlrb', '>= 1.1', '< 3.0'
 

appium_lib.gemspec

@@ -30,37 +30,6 @@ def shell(command, arguments)
         # --relaxed-security
         @driver.execute_script 'mobile: shell', args
       end
-
-      # @deprecated Please use BiDi implementation via `$driver.driver.bidi` directly instead.
-      #
-      # Starts Android logcat broadcast websocket
-      #
-      # @param [String] logcat_file A file path to write messages from a logcat WebSocket client
-      #
-      # @example
-      #
-      #   start_logs_broadcast 'outputfile.log' #=> #<Appium::Android::Command::WsLogcat:...>
-      #
-      def start_logs_broadcast(logcat_file = 'logcat.log')
-        @driver.execute_script 'mobile: startLogsBroadcast'
-
-        socket_url = "ws://#{URI.parse(server_url).host}:#{@core.port}/ws/session/#{@driver.session_id}/appium/device/logcat"
-        @logcat_client = ::Appium::Common::Command::WsLogcat.new(url: socket_url, output_file: logcat_file)
-      end
-
-      # @deprecated Please use BiDi implementation directly instead.
-      #
-      # Stop Android logcat broadcast websocket
-      #
-      # @example
-      #
-      #   stop_logs_broadcast #=> nil
-      #
-      def stop_logs_broadcast
-        @logcat_client.close
-
-        @driver.execute_script 'mobile: stopLogsBroadcast'
-      end
     end
   end
 end

ios_tests/lib/ios/specs/common/command/command.rb

@@ -12,8 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require_relative 'command/ws_logcat'
-
 module Appium
   module Common
     module Command

lib/appium_lib/android/common/command/command.rb

@@ -27,7 +27,6 @@ def self.for(target)
           target.extend Appium::Ios::Xcuitest::Gesture
           target.extend Appium::Ios::Xcuitest::MultiAppHandler
           target.extend Appium::Ios::Xcuitest::Element
-          target.extend Appium::Ios::Xcuitest::Command
           target.extend Appium::Ios::Xcuitest::GetContext
         end
       end

lib/appium_lib/common/command.rb

@@ -17,42 +17,3 @@
 require_relative 'command/source'
 require_relative 'command/multi_app_handler'
 require_relative 'command/get_context'
-
-module Appium
-  module Ios
-    module Xcuitest
-      module Command
-        # @deprecated Please use BiDi implementation via `$driver.driver.bidi` directly instead.
-        #
-        # Starts iOS syslog broadcast websocket
-        #
-        # @param [String] syslog_file A file path to write messages from a syslog WebSocket client
-        #
-        # @example
-        #
-        #   start_logs_broadcast 'outputfile.log' #=> #<Appium::Android::Command::WsLogcat:...>
-        #
-        def start_logs_broadcast(syslog_file = 'syslog.log')
-          @driver.execute_script 'mobile: startLogsBroadcast'
-
-          socket_url = "ws://#{URI.parse(server_url).host}:#{@core.port}/ws/session/#{@driver.session_id}/appium/device/syslog"
-          @logcat_client = ::Appium::Common::Command::WsLogcat.new(url: socket_url, output_file: syslog_file)
-        end
-
-        # @deprecated Please use BiDi implementation directly instead.
-        #
-        # Stop iOS syslog broadcast websocket
-        #
-        # @example
-        #
-        #   stop_logs_broadcast #=> nil
-        #
-        def stop_logs_broadcast
-          @logcat_client.close
-
-          @driver.execute_script 'mobile: stopLogsBroadcast'
-        end
-      end
-    end
-  end
-end