fix test

Author: KazuCocoa

lib/appium_lib_core/common/base/bidi_bridge.rb

@@ -46,9 +46,14 @@ class BiDiBridge < ::Appium::Core::Base::Bridge
         def create_session(capabilities)
           super
 
-          unless @capabilities.nil?
+          return @capabilities if @capabilities.nil?
+
+          begin
             socket_url = @capabilities[:web_socket_url]
             @bidi = ::Selenium::WebDriver::BiDi.new(url: socket_url) if socket_url
+          rescue StandardError => e
+            ::Appium::Logger.warn "WebSocket connection to #{socket_url} for BiDi failed. Error #{e}"
+            raise
           end
 
           @capabilities

lib/appium_lib_core/common/base/driver.rb

@@ -58,7 +58,6 @@ def initialize(bridge: nil, listener: nil, **opts) # rubocop:disable Lint/Missin
           @has_bidi = false
 
           ::Selenium::WebDriver::Remote::Bridge.element_class = ::Appium::Core::Element
-
           bridge ||= create_bridge(**opts)
           add_extensions(bridge.browser)
           @bridge = listener ? ::Appium::Support::EventFiringBridge.new(bridge, listener, **original_opts) : bridge

lib/appium_lib_core/driver.rb

@@ -421,8 +421,8 @@ def start_driver(server_url: nil,
             d_c = DirectConnections.new(@driver.capabilities)
             @driver.update_sending_request_to(protocol: d_c.protocol, host: d_c.host, port: d_c.port, path: d_c.path)
           end
-        rescue Errno::ECONNREFUSED
-          raise "ERROR: Unable to connect to Appium. Is the server running on #{@custom_url}?"
+        rescue Errno::ECONNREFUSED => e
+          raise "ERROR: Unable to connect to Appium. Is the server running on #{@custom_url}? Error: #{e}"
         end
 
         if @http_client.instance_variable_defined? :@additional_headers

test/unit/driver_test.rb

@@ -701,6 +701,10 @@ def test_listener_with_custom_listener_elements
     end
 
     def test_bidi_bridge
+      # Mock the BiDi WebSocket connection using Minitest
+      mock_bidi = Minitest::Mock.new
+      mock_bidi.expect(:close, nil)
+
       android_mock_create_session_w3c_direct = lambda do |core|
         response = {
           value: {
@@ -709,15 +713,18 @@ def test_bidi_bridge
               platformName: :android,
               automationName: ENV['APPIUM_DRIVER'] || 'uiautomator2',
               deviceName: 'Android Emulator',
-              webSocketUrl: 'ws://192.168.1.49:4723/bidi/fbed26aa-e104-42fc-9f5e-b401dc6cc2bc'
+              webSocketUrl: 'ws://127.0.0.1:4723/bidi/fbed26aa-e104-42fc-9f5e-b401dc6cc2bc'
             }
           }
         }.to_json
 
         stub_request(:post, 'http://127.0.0.1:4723/session')
           .to_return(headers: HEADER, status: 200, body: response)
 
-        driver = core.start_driver
+        driver = nil
+        ::Selenium::WebDriver::BiDi.stub(:new, mock_bidi) do
+          driver = core.start_driver
+        end
 
         assert_requested(:post, 'http://127.0.0.1:4723/session', times: 1)
         driver
@@ -730,8 +737,14 @@ def test_bidi_bridge
       driver = android_mock_create_session_w3c_direct.call(core)
 
       assert_equal driver.send(:bridge).class, Appium::Core::Base::BiDiBridge
-      assert_equal driver.instance_variable_get(:@wait_timeout), 30
       assert !driver.send(:bridge).respond_to?(:driver)
+
+      stub_request(:delete, 'http://127.0.0.1:4723/session/1234567890')
+        .to_return(headers: HEADER, status: 200, body: { value: nil }.to_json)
+
+      driver.quit
+      # Verify that close was called exactly once
+      mock_bidi.verify
     end
 
     def test_elements