feat: add BiDiBridge

Author: KazuCocoa

lib/appium_lib_core/common/base/bridge.rb

@@ -21,7 +21,9 @@ def convert(how, what)
         end
       end # LocatorConverter
 
-      class Bridge < ::Selenium::WebDriver::Remote::Bridge
+      # TODO: switch to use BiDiBridge with 'webSocketUrl'
+      class Bridge < ::Selenium::WebDriver::Remote::BiDiBridge
+      # class Bridge < ::Selenium::WebDriver::Remote::Bridge
         include Device::DeviceLock
         include Device::Keyboard
         include Device::ImeActions
@@ -116,6 +118,9 @@ def create_session(capabilities)
           raise ::Selenium::WebDriver::Error::WebDriverError, 'no sessionId in returned payload' unless @session_id
 
           @capabilities = json_create(response['capabilities'])
+
+          socket_url = @capabilities[:web_socket_url]
+          @bidi = ::Selenium::WebDriver::BiDi.new(url: socket_url) if socket_url
         end
 
         # Append +appium:+ prefix for Appium following W3C spec
@@ -313,6 +318,11 @@ def element_screenshot(element_id)
         def send_command(command_params)
           execute :chrome_send_command, {}, command_params
         end
+
+        def quit
+          bidi&.close
+          super
+        end
       end # class Bridge
     end # class Base
   end # module Core

lib/appium_lib_core/common/base/driver.rb

@@ -29,6 +29,9 @@ class Driver < ::Selenium::WebDriver::Driver
         include ::Selenium::WebDriver::DriverExtensions::UploadsFiles
         include ::Selenium::WebDriver::DriverExtensions::HasSessionId
 
+        # TODO: allow to install only for newer version
+        include ::Selenium::WebDriver::DriverExtensions::HasBiDi
+
         include ::Appium::Core::Base::Rotatable
         include ::Appium::Core::Base::TakesScreenshot
         include ::Appium::Core::Base::HasRemoteStatus
@@ -54,6 +57,7 @@ def initialize(bridge: nil, listener: nil, **opts) # rubocop:disable Lint/Missin
           @devtools = nil
           @bidi = nil
 
+          # TODO: modify the eleemnt_class
           # in the selenium webdriver as well
           ::Selenium::WebDriver::Remote::Bridge.element_class = ::Appium::Core::Element
           bridge ||= create_bridge(**opts)