feat: Take down steep issues from 522 to 104#571
Merged
Conversation
… add_rbs_support_for_driver
aguspe
changed the title
aguspe
changed the title
Contributor
Author
|
@KazuCocoa just to let you know I'm still working on this, sorry to trigger the tests so often, is there a way that I could run the pipeline only when the draft is done? Thanks and have a great weekend |
Member
|
Yea, you could comment out triggers in .github directory until you're ready |
Member
|
Especially functional-test.yml |
aguspe
changed the title
… add_rbs_support_for_driver
aguspe
marked this pull request as ready for review
April 6, 2025 09:41
KazuCocoa
approved these changes
Apr 7, 2025
KazuCocoa
left a comment
KazuCocoa
left a comment
Member
There was a problem hiding this comment.
lgtm in my best knowledge. Thank you!
Contributor
Author
|
Great thank you @KazuCocoa I will create another PR from master to continue the steep work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the third PR in our efforts to bring full RBS support to the ruby_lib_core
A lot of support RBS files from Selenium, should be deleted after the Selenium RBS files are available with the gem
We will probably need 2 or 3 extra PRs to add full support, so it will be easier for @KazuCocoa to review, once we managed to get this merged, I will start working on the next PR.
And the results might be affected by the steep upgrade by dependabot here #601.
The end goal is to be able to run type validation on the CI pipeline.
Before the PR:
After the PR:
Motivation and Context
We want to add type support to the core library as specified here #296 so it's easier for new contributors to understand what the methods are expecting and returning.
We also want eventually to be able to run automatic type checks to avoid type errors, and we would like for the RBS files to serve as documentation so the contributors do not need to write as many comments and speed up their flow.