Skip to content

fix: Improving steep setup#655

Merged
KazuCocoa merged 3 commits into
appium:masterfrom
aguspe:fix_steep_errors_and_add_coverage
Dec 23, 2025
Merged

fix: Improving steep setup#655
KazuCocoa merged 3 commits into
appium:masterfrom
aguspe:fix_steep_errors_and_add_coverage

Conversation

@aguspe

@aguspe aguspe commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

This PR adds RBS type signature coverage for all files, and I also added a workflow for type checking, but I can remove it if it's not relevant

  • I added the last missing rbs files, I added the 8 that are just requirement files and one that was missing
Screenshot 2025-12-19 at 14 44 02

@aguspe
aguspe requested a review from KazuCocoa as a code owner December 19, 2025 13:44
Comment thread .github/workflows/type-check.yml Outdated
run: bundle install

- name: Run Steep type check
run: bundle exec rake steep

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle exec rake steep
already runs it, btw

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the unittest.yml/s the line if it would be nice to run it as a separate job

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazuCocoa, it's removed now, thank you for the review!

@KazuCocoa KazuCocoa changed the title Improving steep setup fix: Improving steep setup Dec 23, 2025
@KazuCocoa
KazuCocoa merged commit 3a388b7 into appium:master Dec 23, 2025
25 of 29 checks passed
@KazuCocoa KazuCocoa added the size:XS contribution size: XS label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS contribution size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants