Multi-tier checkpointing + orbax replicator#1332
Closed
ehorning wants to merge 29 commits into
Closed
Conversation
added 14 commits
July 21, 2025 22:04
samos123
reviewed
Aug 15, 2025
added 2 commits
August 15, 2025 21:41
added 3 commits
August 21, 2025 17:26
ehorning
commented
Aug 22, 2025
samos123
reviewed
Sep 16, 2025
| FLAGS = flags.FLAGS | ||
|
|
||
| flags.DEFINE_integer( | ||
| "assume_data_parallelism", |
Contributor
There was a problem hiding this comment.
future follow up. I think orbax has a way of figuring this out automatically since it also needs to know this info. Orbax requires you to specify the batch dimension afair so it can know this.
There was a problem hiding this comment.
MaxText sets it to the number of slices. However it may not be correct if there is intra-slice DDP, so we plan to make it configurable.
DmitryKakurin
approved these changes
Sep 16, 2025
| FLAGS = flags.FLAGS | ||
|
|
||
| flags.DEFINE_integer( | ||
| "assume_data_parallelism", |
There was a problem hiding this comment.
MaxText sets it to the number of slices. However it may not be correct if there is intra-slice DDP, so we plan to make it configurable.
|
This pull request has been automatically marked as stale because it has been inactive for 60 days. It will be closed in 7 days if no further activity occurs. If you would like to continue working on this, please remove the |
|
This pull request was closed because it has been inactive for more than 7 days since being marked as stale. Please feel free to reopen it if you would like to continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate multi-tier checkpointer + orbax replicator into axlearn