Skip to content

Commit 8319ddd

Browse files
committed
refactor: read TORCH_GROUP directly in smoke tests, drop SMOKE_TEST_TORCH_GROUP
Now that the Makefile exports TORCH_GROUP unconditionally, the smoke-test-specific SMOKE_TEST_TORCH_GROUP env var was redundant indirection. ci/nox/noxfile.py reads TORCH_GROUP directly, and `make test-smoke` no longer needs to translate the Makefile variable into a differently-named env var for the nox subprocess.
1 parent 36064a1 commit 8319ddd

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ test-slow:
250250
test-smoke:
251251
@$(call use_env,VENV) && \
252252
echo "Running smoke tests..." && \
253-
SMOKE_TEST_TORCH_GROUP=$(TORCH_GROUP) uv run --no-sync --active nox -f $(MAKEFILE_DIR)ci/nox/noxfile.py -s smoke_tests -- $(PYTEST_ARGS) && \
253+
uv run --no-sync --active nox -f $(MAKEFILE_DIR)ci/nox/noxfile.py -s smoke_tests -- $(PYTEST_ARGS) && \
254254
echo "All smoke tests passed!"
255255

256256
# Run tests on lowest supported PyTorch version (pass PYTEST_ARGS for custom flags)

ci/nox/noxfile.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,16 @@
3535
options.error_on_missing_interpreters = True
3636

3737
# Pins the torch minor version smoke tests install, one of the torch_2_*
38-
# dependency groups in pyproject.toml. Set by the CI matrix (ci.yaml) so each
39-
# job tests a different torch version; defaults to the newest supported.
40-
SMOKE_TEST_TORCH_GROUP = os.environ.get("SMOKE_TEST_TORCH_GROUP", "torch_2_11")
38+
# dependency groups in pyproject.toml — TORCH_GROUP is the project-wide
39+
# source of truth (see Makefile), exported by `make test-smoke` and set per
40+
# job by the CI matrix (ci.yaml); defaults to the newest supported.
41+
TORCH_GROUP = os.environ.get("TORCH_GROUP", "torch_2_11")
4142

4243

4344
@session(
4445
python=get_supported_python_versions(),
4546
uv_extras=["coreai"],
46-
uv_groups=["test", SMOKE_TEST_TORCH_GROUP],
47+
uv_groups=["test", TORCH_GROUP],
4748
)
4849
def smoke_tests(session: Session) -> None:
4950
"""Smoke test the package build and coreai_opt imports and basic functionality.

0 commit comments

Comments
 (0)