Commit 9182e1a
committed
fix(Makefile): narrow TORCH_GROUP override to the setup_env.sh call only
`export TORCH_GROUP=torch_2_X && ...` set the variable for the whole
recipe's shell, which happened to be harmless since nothing else in
these three recipes reads TORCH_GROUP, but the intent was always to
scope the override to just the one setup_env.sh invocation that needs
it. Using `TORCH_GROUP=torch_2_X <command>` as an inline prefix does
that precisely: it applies only to the first command in the `&&`
chain, reverting to the Makefile's own default/command-line value for
everything after.1 parent e4e6adb commit 9182e1a
1 file changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
185 | | - | |
| 184 | + | |
186 | 185 | | |
187 | 186 | | |
188 | 187 | | |
| |||
251 | 250 | | |
252 | 251 | | |
253 | 252 | | |
254 | | - | |
255 | | - | |
| 253 | + | |
256 | 254 | | |
257 | 255 | | |
258 | 256 | | |
| |||
261 | 259 | | |
262 | 260 | | |
263 | 261 | | |
264 | | - | |
265 | | - | |
| 262 | + | |
266 | 263 | | |
267 | 264 | | |
268 | 265 | | |
| |||
0 commit comments