feat(pre-commit): add internal-import alias check with auto-fix#49
Open
dengqiaoyu wants to merge 1 commit into
Open
feat(pre-commit): add internal-import alias check with auto-fix#49dengqiaoyu wants to merge 1 commit into
dengqiaoyu wants to merge 1 commit into
Conversation
- Add an AST-based hook enforcing code style guide §3.3: public modules must `_`-alias symbols imported from private modules; private modules must not - Auto-fix offending import statements and rename in-file references, refusing the fix only when the bound name is shadowed - Register the hook in `.pre-commit-config.yaml` and document it under §3.3 "Enforcement" - Apply across `src/coreai_opt/`, normalizing 27 modules with missing or redundant `_` aliases
dengqiaoyu
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_-alias symbols imported from private modules; private modules must not.pre-commit-config.yamland document it under §3.3 "Enforcement"src/coreai_opt/, normalizing 27 modules with missing or redundant_aliases