Fix port retry in fdb_cluster_fixture by grepping stderr separately

The blob_backup_restore_tests ctest fails on busy CI instances when
ports are already in use by parallel tests. The existing loop retried
on port-in-use errors by grepping the output file for 'Local address
in use', but both stdout and stderr were tee'd to the same output file
via async process substitution, causing races where the grep misses
the error string and the loop exits prematurely.

Fix: tee stderr to a separate file (output.stderr) so the grep for
'Local address in use' is reliable and not corrupted by interleaved
stdout. Non-port-in-use failures still fail immediately with stderr
printed for debugging.

Author: michael stack

fdbclient/tests/fdb_cluster_fixture.sh

@@ -136,7 +136,7 @@ function start_fdb_cluster {
       --storage_count "${ss_count}" --storage_type ssd-rocksdb-v1 \
       --dump_pids on \
       > >(tee "${output}") \
-      2> >(tee "${output}" >&2)
+      2> >(tee "${output}.stderr" >&2)
     status="$?"
     # Restore exit on error.
     set -o errexit  # a.k.a. set -e
@@ -171,13 +171,14 @@ function start_fdb_cluster {
       fi
       break;
     fi
-    # Otherwise, look for 'Local address in use' and if found retry with different ports.
-    # Use grep -a to treat binary files as text
-    if grep -a 'Local address in use' "${output}"; then
-      log "Ports in use; retry cluster start but with different ports"
+    # Check stderr (separate file to avoid tee process substitution race) for
+    # port-in-use error. Only retry on port collision; fail on anything else.
+    if grep -a 'Local address in use' "${output}.stderr"; then
+      log "Port ${port_prefix} in use, retrying with next port"
       continue
     fi
-    err "Failed to start fdb cluster"
+    err "Failed to start fdb cluster (stderr follows):"
+    cat "${output}.stderr" >&2
     return 1
   done
 }