Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/inline-buggify-function

# Conflicts:
#	fdbserver/core/ServerKnobs.cpp
#	fdbserver/tlog/TLogServer.cpp

Author: tclinkenbeard-oai

.clang-tidy

@@ -1,14 +1,21 @@
 ---
 Checks: >
   -*,
+  bugprone-shared-ptr-array-mismatch,
   bugprone-sizeof-expression,
+  bugprone-string-constructor,
+  bugprone-suspicious-memory-comparison,
+  bugprone-suspicious-memset-usage,
+  bugprone-suspicious-semicolon,
   bugprone-suspicious-string-compare,
+  bugprone-unique-ptr-array-mismatch,
   bugprone-use-after-move,
   modernize-use-auto,
   modernize-use-equals-default,
   modernize-use-override,
   modernize-use-using,
   performance-for-range-copy,
+  performance-move-const-arg,
   readability-container-contains,
   readability-const-return-type,
   readability-container-size-empty,

.github/instructions/*.instructions.md .github/copilot-instructions.md.github/instructions/*.instructions.md renamed to .github/copilot-instructions.md

@@ -19,6 +19,5 @@ jobs:
           days-before-pr-stale: 150
           days-before-close: 14
           days-before-issue-stale: 5475 # 15 years, basically disabled for issues
-          # throttled to 20 per day
-          operations-per-run: 20
+          operations-per-run: 80 # operating on one PR can use multiple "operations"
           ascending: true

.github/workflows/stale.yml

@@ -2,43 +2,44 @@ name: Windows Boost CONFIG Test
 
 on:
   pull_request:
+    branches:
+      - main
   push:
     branches:
-      - 'test-*'
+      - main
       - 'boost-*'
-  workflow_dispatch:
 
 permissions:
   contents: read
 
 jobs:
   test-windows-boost:
     name: Test Boost CONFIG Mode on Windows
-    runs-on: windows-latest
-    
+    runs-on: windows-2025
+
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
-      
-      - name: Setup CMake
-        uses: lukka/get-cmake@latest
-      
+
       - name: Install Boost via vcpkg
+        shell: cmd
         run: |
-          vcpkg install boost-filesystem:x64-windows boost-iostreams:x64-windows boost-serialization:x64-windows boost-system:x64-windows boost-program-options:x64-windows boost-url:x64-windows boost-context:x64-windows lz4:x64-windows
+          vcpkg install boost-filesystem:x64-windows      ^
+                        boost-iostreams:x64-windows       ^
+                        boost-serialization:x64-windows   ^
+                        boost-system:x64-windows          ^
+                        boost-program-options:x64-windows ^
+                        boost-url:x64-windows             ^
+                        boost-context:x64-windows         ^
+                        lz4:x64-windows
+
+      - name: Configure and Build FoundationDB
         shell: cmd
-        
-      - name: Configure and Build FoundationDB (without Swift)
         run: |
           mkdir build
           cd build
-          cmake .. -DCMAKE_TOOLCHAIN_FILE=%VCPKG_INSTALLATION_ROOT%\scripts\buildsystems\vcpkg.cmake -DCMAKE_BUILD_TYPE=Release -DWITH_SWIFT=OFF -DBUILD_TESTING=OFF -DBUILD_DOCUMENTATION=OFF -DWITH_CSHARP=OFF
-        shell: cmd
-      
-      - name: Verify Build Success
-        run: |
-          echo "Build completed successfully - Boost CONFIG mode works on Windows!"
-        shell: cmd
-      
+          cmake .. -DCMAKE_TOOLCHAIN_FILE=%VCPKG_INSTALLATION_ROOT%\scripts\buildsystems\vcpkg.cmake ^
+                   -DCMAKE_BUILD_TYPE=Release -DWITH_SWIFT=OFF -DBUILD_TESTING=OFF -DBUILD_DOCUMENTATION=OFF -DWITH_CSHARP=OFF
+
       - name: Report Success
         run: echo "✓ Boost CONFIG mode working on Windows!"

.github/workflows/windows-boost-test.yml

@@ -140,7 +140,7 @@ Building FoundationDB requires at least 8GB of memory. More memory is needed whe
 
 ### macOS
 
-The build under macOS will work the same way as on Linux. [Homebrew](https://brew.sh/) can be used to install the `boost` library and the `ninja` build tool. Be carefull, curent main branch use boost 1.86, do install this version or just let cmake download one. Also, if swift binding is not interest, use -DBUILD_SWIFT_BINDING=OFF.
+The build under macOS will work the same way as on Linux. [Homebrew](https://brew.sh/) can be used to install the `boost` library and the `ninja` build tool. Be careful, current main branch uses boost 1.86, do install this version or just let cmake download one. Also, if the Swift binding is not of interest, use -DBUILD_SWIFT_BINDING=OFF.
 
 ```sh
 cmake -G Ninja <FDB_SOURCE_DIR> -B <BUILD_DIR>

README.md

@@ -105,7 +105,7 @@ class ApiWorkload : public WorkloadBase, IWorkloadControlIfc {
 	// In-memory store maintaining expected database state
 	std::unordered_map<std::optional<int>, KeyValueStore> stores;
 
-	ApiWorkload(const WorkloadConfig& config);
+	explicit ApiWorkload(const WorkloadConfig& config);
 
 	// Methods for generating random keys and values
 	fdb::Key randomKeyName();

bindings/c/test/apitester/TesterApiWorkload.h

@@ -34,7 +34,7 @@ using fdb::ValueRef;
 
 class AtomicOpsCorrectnessWorkload : public ApiWorkload {
 public:
-	AtomicOpsCorrectnessWorkload(const WorkloadConfig& config) : ApiWorkload(config) {}
+	explicit AtomicOpsCorrectnessWorkload(const WorkloadConfig& config) : ApiWorkload(config) {}
 
 private:
 	using IntAtomicOpFunction = std::function<uint64_t(uint64_t, uint64_t)>;

bindings/c/test/apitester/TesterAtomicOpsCorrectnessWorkload.cpp

@@ -25,7 +25,7 @@ namespace FdbApiTester {
 
 class CancelTransactionWorkload : public ApiWorkload {
 public:
-	CancelTransactionWorkload(const WorkloadConfig& config) : ApiWorkload(config) {}
+	explicit CancelTransactionWorkload(const WorkloadConfig& config) : ApiWorkload(config) {}
 
 private:
 	enum OpType { OP_CANCEL_GET, OP_CANCEL_AFTER_FIRST_GET, OP_LAST = OP_CANCEL_AFTER_FIRST_GET };

bindings/c/test/apitester/TesterCancelTransactionWorkload.cpp

@@ -27,7 +27,7 @@ namespace FdbApiTester {
 
 class ApiCorrectnessWorkload : public ApiWorkload {
 public:
-	ApiCorrectnessWorkload(const WorkloadConfig& config) : ApiWorkload(config) {}
+	explicit ApiCorrectnessWorkload(const WorkloadConfig& config) : ApiWorkload(config) {}
 
 private:
 	enum OpType {

bindings/c/test/apitester/TesterCorrectnessWorkload.cpp

@@ -28,7 +28,7 @@ class SetAndGetWorkload : public WorkloadBase {
 	fdb::Key keyPrefix;
 	Random random;
 
-	SetAndGetWorkload(const WorkloadConfig& config) : WorkloadBase(config) {
+	explicit SetAndGetWorkload(const WorkloadConfig& config) : WorkloadBase(config) {
 		keyPrefix = fdb::toBytesRef(fmt::format("{}/", workloadId));
 	}