Skip to content

Commit da42873

Browse files
author
michael stack
committed
Log DD exit reason as DDExiting at SevWarn
DD exits (e.g. movekeys_conflict) were invisible because reportErrorsExcept suppresses logging for "normal" DD errors. Add DDExiting trace event at SevWarn with error and code so every DD death is visible in trace logs.
1 parent d92e5ea commit da42873

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

fdbserver/DataDistribution.actor.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1168,6 +1168,12 @@ ACTOR Future<Void> dataDistribution(Reference<DataDistributor> self,
11681168
trackerCancelled = true;
11691169
state Error err = e;
11701170
TraceEvent("DataDistributorDestroyTeamCollections").error(e);
1171+
// Log every DD exit with the reason. movekeys_conflict is the most common
1172+
// non-kill cause — it's a normal internal restart, but was previously
1173+
// invisible because reportErrorsExcept suppresses logging for "normal" DD errors.
1174+
TraceEvent(SevWarn, "DDExiting", self->ddId)
1175+
.error(e)
1176+
.detail("ErrorCode", e.code());
11711177
state std::vector<UID> teamForDroppedRange;
11721178
if (removeFailedServer.getFuture().isReady() && !removeFailedServer.getFuture().isError()) {
11731179
// Choose a random healthy team to host the to-be-dropped range.

0 commit comments

Comments
 (0)