Skip to content

Commit e95820e

Browse files
author
michael stack
committed
Fix comment
1 parent da42873 commit e95820e

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

fdbserver/DataDistribution.actor.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,8 @@ struct DataDistributor : NonCopyable, ReferenceCounted<DataDistributor> {
514514
// DDInitUpdatedReplicaKeys - Replica keys updated
515515
// DDInitSlowDataMoveRead - (SevWarn) dataMoveKeys read taking >5s
516516
// DDInitServerListAndDataMoveReadComplete - Server list + data moves read: NumDataMoves, NumServers,
517-
// ElapsedSeconds DDInitKeyServerScanProgress - (every 30s) keyServer scan: BeginKey, Batches, ShardsScanned
517+
// ElapsedSeconds
518+
// DDInitKeyServerScanProgress - (every 30s) keyServer scan: BeginKey, Batches, ShardsScanned
518519
// DDInitKeyServerScanComplete - keyServer scan done: NumShards, ElapsedSeconds
519520
// DDInitGotInitialDD - Init data loaded: NumShards, NumServers
520521
// DDInitDataLoaded - Init data loaded, ElapsedSeconds (does NOT mean DD is fully operational)
@@ -1171,9 +1172,7 @@ ACTOR Future<Void> dataDistribution(Reference<DataDistributor> self,
11711172
// Log every DD exit with the reason. movekeys_conflict is the most common
11721173
// non-kill cause — it's a normal internal restart, but was previously
11731174
// invisible because reportErrorsExcept suppresses logging for "normal" DD errors.
1174-
TraceEvent(SevWarn, "DDExiting", self->ddId)
1175-
.error(e)
1176-
.detail("ErrorCode", e.code());
1175+
TraceEvent(SevWarn, "DDExiting", self->ddId).error(e).detail("ErrorCode", e.code());
11771176
state std::vector<UID> teamForDroppedRange;
11781177
if (removeFailedServer.getFuture().isReady() && !removeFailedServer.getFuture().isError()) {
11791178
// Choose a random healthy team to host the to-be-dropped range.

0 commit comments

Comments
 (0)