Generalize the pipefail false-negatives fix from #12919#12921
Merged
Conversation
Move output_contains from s3client_test.sh to tests_common.sh and add output_matches, output_matches_i, output_matches_E variants for regex and case-insensitive matching. All use here-strings (<<<) instead of echo|grep pipes, avoiding false negatives from SIGPIPE when pipefail is enabled. Convert 26 of 28 echo|grep -q instances across test scripts. Two chained grep patterns (grep -i | grep -qvi) are left unchanged. Also make backup_tests_common.sh source tests_common.sh so the helpers are available in backup test utilities.
Contributor
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
tclinkenbeard-oai
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move output_contains from s3client_test.sh to tests_common.sh and add output_matches, output_matches_i, output_matches_E variants for regex and case-insensitive matching. All use here-strings (<<<) instead of echo|grep pipes, avoiding false negatives from SIGPIPE when pipefail is enabled.
Convert 26 of 28 echo|grep -q instances across test scripts. Two chained grep patterns (grep -i | grep -qvi) are left unchanged.
Also make backup_tests_common.sh source tests_common.sh so the helpers are available in backup test utilities.