Skip to content

Allow fdbdecode to resolve timestamps#13202

Open
johscheuer wants to merge 2 commits into
apple:mainfrom
johscheuer:fdbdecode-timestamp-parsing
Open

Allow fdbdecode to resolve timestamps#13202
johscheuer wants to merge 2 commits into
apple:mainfrom
johscheuer:fdbdecode-timestamp-parsing

Conversation

@johscheuer
Copy link
Copy Markdown
Contributor

@johscheuer johscheuer commented May 12, 2026

Allow fdbdecode to resolve timestamps instead of requiring versions. It uses the same approach as the fdbbackup binary.

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 672e5cc
  • Duration 0:03:40
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 672e5cc
  • Duration 0:04:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 672e5cc
  • Duration 0:04:23
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 672e5cc
  • Duration 0:04:26
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 672e5cc
  • Duration 0:04:38
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; if [[ $FDB_VERSION =~ 7\.\3. ]]; then echo skip; else exit 1; fi; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 672e5cc
  • Duration 0:33:13
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 672e5cc
  • Duration 0:44:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 0:25:01
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 0fffb93
  • Duration 0:28:07
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login ./build_pr_macos.sh. Reason: exit status 254
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 0fffb93
  • Duration 0:34:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 0fffb93
  • Duration 0:45:54
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 0:55:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 1:03:45
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

saintstack
saintstack approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 1:06:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@johscheuer johscheuer closed this May 12, 2026
@johscheuer johscheuer reopened this May 12, 2026
neethuhaneesha
neethuhaneesha reviewed May 12, 2026
View reviewed changes
Comment thread fdbbackup/FileDecoder.cpp
}

// Reject combining a timestamp and a version filter for the same bound.
if (param->beginTimestamp.present() && param->beginVersionFilter != 0) {
Copy link
Copy Markdown
Contributor

@neethuhaneesha neethuhaneesha May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we checking if the timestamp is passed in the correct format or not?

Comment thread fdbbackup/FileDecoder.cpp
Database db = Database::createDatabase(params->clusterFile, ApiVersion::LATEST_VERSION);
if (params->beginTimestamp.present()) {
params->beginVersionFilter = co_await timeKeeperVersionFromDatetime(params->beginTimestamp.get(), db);
TraceEvent("TimestampResolved")
Copy link
Copy Markdown
Contributor

@neethuhaneesha neethuhaneesha May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit; BeginTimeStampResolved ? just to easily figure out whether it is begin or end.

Comment thread fdbbackup/FileDecoder.cpp
.detail("Version", params->beginVersionFilter);
}
if (params->endTimestamp.present()) {
params->endVersionFilter = co_await timeKeeperVersionFromDatetime(params->endTimestamp.get(), db);
Copy link
Copy Markdown
Contributor

@neethuhaneesha neethuhaneesha May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fail if the version is not found?

Comment thread fdbbackup/FileDecoder.cpp
.detail("Timestamp", params->endTimestamp.get())
.detail("Version", params->endVersionFilter);
}
}
Copy link
Copy Markdown
Contributor

@neethuhaneesha neethuhaneesha May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check if param->endVersionFilter is > params->beginVersionFilter

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 0:31:44
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 0fffb93
  • Duration 0:33:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 0fffb93
  • Duration 0:45:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 1:11:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 1:12:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 0fffb93
  • Duration 1:13:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented May 12, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 0fffb93
  • Duration 1:23:55
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neethuhaneesha neethuhaneesha neethuhaneesha left review comments

@saintstack saintstack saintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johscheuer @foundationdb-ci @saintstack @neethuhaneesha