fix backups list: include region in backup urls#13231
Open
Pranav2612000 wants to merge 1 commit into
Open
Conversation
saintstack
reviewed
May 18, 2026
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Looks right. Are there other places in
| params.append("region="); | ||
| params.append(region); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Formatting seems odd here (tabs vs spaces?). Is there a unit test for this method that you could add too? Otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
regionparam in the backup urls returned on running backup listWhy do we need this change?
regionparam to list backups, the returned backups do not have theregionparam. This makes the backup incorrect as trying to run operations ( e.g start, describe ) on an item of this list will fail