Report backup worker roles in status json by tclinkenbeard-oai · Pull Request #13237 · apple/foundationdb

tclinkenbeard-oai · 2026-05-18T21:52:24Z

Previously, this role was missing from status json output, inconsistent with other roles. Following a similar pattern as already exists for other roles, this PR fixes this gap

foundationdb-ci · 2026-05-18T22:16:17Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 1675f12
Duration 0:23:41
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

tclinkenbeard-oai

Generated by Codex.

What is it trying to do?

This PR adds backup workers to status json role reporting. Today, Status.cpp already records several cluster roles plus log routers from both current and old log-system configurations, but it omits backupWorkers. The patch fills that gap by adding "backup" roles in both places.

Is it correct?

Yes, this looks correct.

The change is narrowly scoped to status-json assembly and mirrors the existing log-router handling:

it walks backupWorkers in the current tLogs configuration,
does the same for old tLog configurations,
only emits present interfaces,
and reuses the generic RolesInfo::addRole(...) path already used for comparable role entries.

I also checked that this does not touch serialization, wire formats, actor control flow, or runtime recruitment behavior; it only changes emitted status metadata.

GitHub currently exposes no check runs for the PR head commit, so there is no visible CI result to weigh here. I did not run build or test validation.

Are there bugs?

I did not find any correctness bugs.

Are there omissions?

A focused regression test or status-json fixture that exercises enabled backup workers and asserts the emitted "backup" role would make this harder to regress. I do not think that omission blocks this small fix.

Are there better ways of doing things?

The current approach is the right shape for this file: it keeps backup-worker reporting aligned with the existing role-discovery logic for routers and old log generations. The only concrete improvement I would suggest is adding the targeted status-json coverage noted above.

Should this CL be LGTMd?

Yes, LGTM.

I inspected the changed status-role construction, the shared RolesInfo::addRole(...) path, and the surrounding backup-worker configuration plumbing. The highest remaining risk is simply the lack of a focused regression test for backup-worker visibility in status json, not a flaw in the implementation itself.

foundationdb-ci · 2026-05-18T22:25:35Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 1675f12
Duration 0:32:59
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-18T22:38:46Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 1675f12
Duration 0:46:10
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-18T22:50:39Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 1675f12
Duration 0:58:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-18T22:54:38Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 1675f12
Duration 1:02:05
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-18T23:01:38Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 1675f12
Duration 1:09:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

neethuhaneesha · 2026-05-18T23:32:28Z

 		}
+		for (auto& backupWorker : tLogSet.backupWorkers) {
+			if (backupWorker.present()) {
+				roles.addRole("backup", backupWorker.interf());


Can you please make it backupworker, just to specific and not confused with backup agents

foundationdb-ci · 2026-05-18T23:47:31Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 1675f12
Duration 1:54:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-19T17:01:38Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: 50c93ab
Duration 0:38:39
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-19T17:08:19Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: 50c93ab
Duration 0:45:19
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-19T17:15:38Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 50c93ab
Duration 0:52:35
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-19T17:33:14Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: 50c93ab
Duration 1:10:15
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-19T17:38:33Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: 50c93ab
Duration 1:15:33
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-05-19T17:42:43Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: 50c93ab
Duration 1:19:44
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-19T17:59:42Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 50c93ab
Duration 1:36:42
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login ./build_pr_macos.sh. Reason: exit status 254
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

neethuhaneesha

Thanks!

…kup-worker-status-json

foundationdb-ci · 2026-05-20T16:57:50Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: bff4ad5
Duration 0:26:41
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T17:05:21Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: bff4ad5
Duration 0:34:09
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T17:05:48Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: bff4ad5
Duration 0:34:38
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login ./build_pr_macos.sh. Reason: exit status 254
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T17:16:17Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: bff4ad5
Duration 0:45:04
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T17:26:29Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: bff4ad5
Duration 0:55:19
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T17:31:43Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: bff4ad5
Duration 1:00:33
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T17:41:05Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: bff4ad5
Duration 1:09:54
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-05-20T20:24:33Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: bff4ad5
Duration 0:35:59
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T20:35:38Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: bff4ad5
Duration 0:47:05
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T20:46:44Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: bff4ad5
Duration 0:58:10
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T20:56:52Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: bff4ad5
Duration 1:08:20
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T21:06:02Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: bff4ad5
Duration 1:17:26
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2026-05-20T21:15:49Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: bff4ad5
Duration 1:27:17
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-20T23:38:33Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: bff4ad5
Duration 3:50:01
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

…kup-worker-status-json

foundationdb-ci · 2026-05-21T00:58:22Z

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Commit ID: beadb7b
Duration 0:30:49
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-21T01:00:11Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: beadb7b
Duration 0:32:41
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-21T01:11:23Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: beadb7b
Duration 0:43:21
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-21T01:14:30Z

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Commit ID: beadb7b
Duration 0:46:56
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-21T01:30:33Z

Result of foundationdb-pr-clang on Linux RHEL 9

Commit ID: beadb7b
Duration 1:02:59
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-21T01:31:52Z

Result of foundationdb-pr on Linux RHEL 9

Commit ID: beadb7b
Duration 1:04:18
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2026-05-21T01:37:11Z

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Commit ID: beadb7b
Duration 1:09:37
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

Report backup worker roles in status json

1675f12

tclinkenbeard-oai commented May 18, 2026

View reviewed changes

neethuhaneesha reviewed May 18, 2026

View reviewed changes

neethuhaneesha added the Backup_v2 Partitioned Log Backup label May 19, 2026

s/backup/backupworker

50c93ab

tclinkenbeard-oai requested a review from neethuhaneesha May 19, 2026 23:37

neethuhaneesha approved these changes May 20, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/bac…

bff4ad5

…kup-worker-status-json

tclinkenbeard-oai closed this May 20, 2026

tclinkenbeard-oai reopened this May 20, 2026

tclinkenbeard-oai mentioned this pull request May 20, 2026

Decrease expectedRate for MoveKeysCycle test #13252

Merged

Merge remote-tracking branch 'origin/main' into dev/tclinkenbeard/bac…

beadb7b

…kup-worker-status-json

tclinkenbeard-oai merged commit edc55dc into apple:main May 21, 2026
7 checks passed

Uh oh!

Conversation

tclinkenbeard-oai commented May 18, 2026

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

tclinkenbeard-oai left a comment

Choose a reason for hiding this comment

What is it trying to do?

Is it correct?

Are there bugs?

Are there omissions?

Are there better ways of doing things?

Should this CL be LGTMd?

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

neethuhaneesha May 18, 2026

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented May 18, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 19, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

neethuhaneesha left a comment

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented May 20, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 20, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented May 20, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented May 20, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

Uh oh!

foundationdb-ci commented May 20, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 20, 2026

Result of foundationdb-pr on Linux RHEL 9

Uh oh!

foundationdb-ci commented May 20, 2026