Skip to content

prevent infinity waiting on remote DC in multiregional mode when failover #12071 #13295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkSh1 wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −1
Open

prevent infinity waiting on remote DC in multiregional mode when failover #12071 #13295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a22692
prevent infinity wait for ALL_LOGS_RECRUITED on remote DC TC when the…
MarkSh1 May 28, 2026
b363e11
applied the clang format to DataDistribution.cpp
MarkSh1 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion fdbserver/datadistributor/DataDistribution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,14 @@ Future<Void> StorageWiggler::finishWiggle() {
});
}

Future<Void> waitForAcceptingCommits(Reference<AsyncVar<ServerDBInfo> const> db) {
TraceEvent("DDWaitForAcceptingCommitsStart").log();
while (db->get().recoveryState < RecoveryState::ACCEPTING_COMMITS) {
TraceEvent("DDWaitForAcceptingCommits").detail("RecoveryState", (int)db->get().recoveryState);
co_await db->onChange();
}
}

Future<Void> remoteRecovered(Reference<AsyncVar<ServerDBInfo> const> db) {
TraceEvent("DDTrackerStarting").log();
while (db->get().recoveryState < RecoveryState::ALL_LOGS_RECRUITED) {
Expand Down Expand Up @@ -2900,7 +2908,11 @@ Future<Void> dataDistribution(Reference<DataDistributor> self,
self->configuration,
self->remoteDcIds,
Optional<std::vector<Optional<Key>>>(),
self->initialized.getFuture() && remoteRecovered(self->dbInfo),
// In multi-region configurations DD only needs the cluster to
// reach ACCEPTING_COMMITS before continuing startup. Waiting for
// ALL_LOGS_RECRUITED can hang during degraded failover scenarios
// such as when the primary DC is down.
self->initialized.getFuture() && waitForAcceptingCommits(self->dbInfo),
zeroHealthyTeams[1],
IsPrimary::False,
processingUnhealthy,
Expand Down
Loading