Skip to content

Add fdbbackup initial snapshot interval to help #13299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiangRuoShui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fdbbackup initial snapshot interval to help #13299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fdbbackup/backup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,9 @@ static void printBackupUsage(bool devhelp) {
" For start or modify operations, specifies the backup's default target snapshot interval "
"as DURATION seconds. Defaults to %d for start operations.\n",
CLIENT_KNOBS->BACKUP_DEFAULT_SNAPSHOT_INTERVAL_SEC);
printf(" --initial-snapshot-interval DURATION\n"
" For start operations, specifies the duration of the first inconsistent snapshot as DURATION "
"seconds. Defaults to 0, meaning as fast as possible.\n");
printf(" --mode MODE Snapshot mechanism to use: bulkdump, rangefile (default, legacy), or both.\n"
" bulkdump: Uses BulkDump SST files for faster restore performance\n"
" rangefile: Traditional range files for backward compatibility\n"
Expand Down
6 changes: 6 additions & 0 deletions tests/argument_parsing/test_argument_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ def test_fdbbackup(build_dir):
check(not is_unknown_knob(run_command(command, ["--knob_min_trace_severity", "5"])))
check(not is_unknown_knob(run_command(command, ["--knob_min-trace-severity", "5"])))

start_command = [args.build_dir + "/bin/fdbbackup", "start"]
check(
"--initial-snapshot-interval DURATION"
in run_command(start_command, ["--help"])
)


if __name__ == "__main__":
parser = argparse.ArgumentParser(
Expand Down
Loading