Skip to content

Move ProcessClass and ClusterRole out of fdbrpc#13399

Merged
tclinkenbeard-oai merged 7 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/move-process-class
Jul 8, 2026
Merged

Move ProcessClass and ClusterRole out of fdbrpc#13399
tclinkenbeard-oai merged 7 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/move-process-class

Conversation

@tclinkenbeard-oai

Copy link
Copy Markdown
Collaborator

This PR builds on previous PRs to shrink fdbrpc by extracting FDB-specific logic. This makes the library more generic and improves compilation times.

The PR moves ProcessClass into fdbclient, moves simulator-only process metadata into fdbserver/core, and places recruitment policy (ClusterRole, Fitness, and machineClassFitness) in fdbserver/core. This leaves fdbclient with only the serialized process-class representation while removing FDB-specific server and simulation concepts from fdbrpc.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 591747d
  • Duration 0:22:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: 591747d
  • Duration 0:32:47
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: 591747d
  • Duration 0:45:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 591747d
  • Duration 0:46:42
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: 591747d
  • Duration 0:47:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 591747d
  • Duration 0:47:31
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 591747d
  • Duration 1:06:20
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@gxglass gxglass left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local AI is saying a rebase is needed

…e-process-class

# Conflicts:
#	fdbrpc/include/fdbrpc/Locality.h
#	fdbserver/clustercontroller/ClusterController.h
#	fdbserver/core/LeaderElection.cpp
@tclinkenbeard-oai
tclinkenbeard-oai requested a review from gxglass July 8, 2026 16:56
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 648f425
  • Duration 0:24:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: 648f425
  • Duration 0:45:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: 648f425
  • Duration 0:58:35
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 648f425
  • Duration 1:00:49
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: 648f425
  • Duration 1:01:14
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 648f425
  • Duration 1:05:44
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 648f425
  • Duration 2:11:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 581022f
  • Duration 0:22:15
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: 581022f
  • Duration 0:32:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: 581022f
  • Duration 0:45:40
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 581022f
  • Duration 0:56:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 581022f
  • Duration 0:57:57
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@tclinkenbeard-oai
tclinkenbeard-oai merged commit 7899e34 into apple:main Jul 8, 2026
7 of 10 checks passed
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 581022f
  • Duration 2:12:01
  • Result: ❌ FAILED
  • Error: `Error while executing command: cd ${CODEBUILD_SRC_DIR}

summary / time info

for f in fdb-kubernetes-/logs/.log); do
echo ; echo "$f :"
grep -A3 -E '^Ran [0-9]+ of [0-9]+ Specs in' "$f" || echo "TIMEOUT/PANIC"
done

check all fail types

fail_test=false
if [ -n "${FDB_K8S_TESTS_FAIL:-}" ]; then
echo "FAIL: fdb-kubernetes-tests"
fail_test=true
fi
if [ -n "${FDB_E2E_TESTS_FAIL:-}" ]; then
echo "FAIL: fdb-kubernetes-operator/e2e tests"
fail_test=true
fi

Check for test failures where one or more tests have failed for a test suite.

if grep -q -- "--- FAIL:" fdb-kubernetes-/logs/.log ; then
for f in $(grep -l -- "--- FAIL:" fdb-kubernetes-/logs/.log); do
echo "======================================================================"
echo "FAILED: $f"
echo "++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++"
tail -n90 "$f"
echo "----------------------------------------------------------------------"
done
fail_test=true
fi

Check for all tests that have not finished e.g. because they timed out or they paniced during the execution.

for f in $(grep -L -- "SUCCESS! --" fdb-kubernetes-/logs/.log); do
if ! grep -q -- "--- FAIL:" $f; then
echo "======================================================================"
echo "TIMEOUT/PANIC: $f"
echo "++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++"
tail -n90 "$f"
echo "----------------------------------------------------------------------"
fail_test=true
fi
done
. Reason: exit status 2`

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: 581022f
  • Duration 2:57:00
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants