Allow restored data moves to split ordinary relocations

[tclinkenbeard-oai]

Test failure: tests/fast/DDPipelineSaturation.toml hit a simulator assertion because a restore relocation reached a path that forbade restore moves.

Bug: A simulation assertion rejected a restored data move that legitimately split an ordinary in-flight SizeSplit relocation.

Fix: Reject only partial restored-over-restored overlap; preserve cancel, split, and relaunch for ordinary fragments.

Validation: The exact tuple passed through simulated time 417.792 versus the original assertion at 102.710699; the combined same-base replay preserved the pre-failure trace and passed; 43/43 data-distributor tests passed.

[tclinkenbeard-oai]

Generated by Codex.

What is it trying to do?

Allow a restored data move to split an overlapping ordinary in-flight relocation. The residual ordinary fragments are relaunched normally, while partial restored-over-restored overlap remains rejected.

Is it correct?

Yes. In the affected-range loop, the incoming restored move retains its original DataMove and ID only for its exact range. Other affected fragments reset dataMove and receive a fresh ID. The new assertion precisely permits an ordinary residual fragment while continuing to reject a residual restored fragment.

I inspected the changed path, restore construction and launch flow, in-flight cancellation/relaunch behavior, and downstream restored-move handling. There are no serialization or compatibility changes, no added hot-path work, and no altered async lifetime behavior.

No build or test validation was run as part of this review. GitHub’s clang-format, clang-tidy, and Windows Boost checks are green; the FoundationDB builders and cluster tests are still pending.

Are there bugs?

I did not find any correctness bugs.

Are there omissions?

No blocking omissions. A dedicated regression test could make the restore-over-ordinary split case more explicit, but the PR identifies the existing simulation workload and exact failing tuple that exercised the assertion.

Are there better ways of doing things?

The localized assertion change is the right scope. Expanding this into broader relocation-queue restructuring would add risk without improving the fix.

Should this CL be LGTMd?

Yes, LGTM from code inspection. The highest remaining risk is whether the reported simulation reproduction fully covers the intended overlap shape; final landing should still wait for the pending public CI contexts.

[foundationdb-ci]

Result of foundationdb-pr-clang-arm on Linux RHEL 9

• Commit ID: ea3298f
• Duration 0:44:34
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux RHEL 9

• Commit ID: ea3298f
• Duration 1:00:47
• Result: ❌ FAILED
• Error: Build has timed out.
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux RHEL 9

• Commit ID: ea3298f
• Duration 1:28:02
• Result: ❌ FAILED
• Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux RHEL 9

• Commit ID: ea3298f
• Duration 1:36:48
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS 14.x

• Commit ID: ea3298f
• Duration 1:44:36
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

• Commit ID: ea3298f
• Duration 4:00:30
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS 14.x

• Commit ID: ea3298f
• Duration 4:42:19
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:22:19
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS 14.x

• Commit ID: f7c03d4
• Duration 0:33:09
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:46:10
• Result: ❌ FAILED
• Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:48:46
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-arm on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:49:40
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS 14.x

• Commit ID: f7c03d4
• Duration 0:50:35
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 1:34:34
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:29:51
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-arm on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:45:06
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS 14.x

• Commit ID: f7c03d4
• Duration 0:46:14
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS 14.x

• Commit ID: f7c03d4
• Duration 0:48:42
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 0:53:03
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 1:04:20
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

• Commit ID: f7c03d4
• Duration 1:43:23
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)